Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #44731. #44860

Merged
merged 1 commit into from
Oct 7, 2017
Merged

Fix issue #44731. #44860

merged 1 commit into from
Oct 7, 2017

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Sep 26, 2017

Also excludes impl Trait from everybody_loops if it appears in the path.

Fixes #44731.

Also excludes `impl Trait` from everybody_loops if it appears in the path.
@rust-highfive
Copy link
Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor

arielb1 commented Sep 26, 2017

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned arielb1 Sep 26, 2017
@arielb1 arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2017
@carols10cents
Copy link
Member

review ping @nrc ! pinging you on IRC too!

@shepmaster
Copy link
Member

Ping @rust-lang/dev-tools! It's been Over 6 days since we heard from @nrc, it may be time to assign a new reviewer!

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 6, 2017

📌 Commit 16c110f has been approved by alexcrichton

@alexcrichton alexcrichton assigned alexcrichton and unassigned nrc Oct 6, 2017
@alexcrichton alexcrichton added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2017
@bors
Copy link
Contributor

bors commented Oct 7, 2017

⌛ Testing commit 16c110f with merge d2f71bf...

bors added a commit that referenced this pull request Oct 7, 2017
Fix issue #44731.

Also excludes `impl Trait` from everybody_loops if it appears in the path.

Fixes #44731.
@bors
Copy link
Contributor

bors commented Oct 7, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing d2f71bf to master...

@bors bors merged commit 16c110f into rust-lang:master Oct 7, 2017
@kennytm kennytm deleted the fix-44731 branch October 7, 2017 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants