Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TcpStream::local_addr docs example code #44913

Merged
merged 2 commits into from
Oct 7, 2017
Merged

Conversation

leavehouse
Copy link
Contributor

The local address's port is not 8080 in this example, that's the remote peer address port. On my machine, the local address is different every time, so I've changed assert_eq to only test the IP address

The local address's port is not 8080 in this example, that's the remote peer address port. On my machine, the local address is different every time, so I've changed `assert_eq` to only test the IP address
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Add a missing import and remove unused imports
@shepmaster
Copy link
Member

Thanks, @leavehouse! We'll get our crack team of reviewers on this shortly!

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2017
@aidanhs aidanhs added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2017
@BurntSushi
Copy link
Member

Seems reasonable to me! @bors r+

@bors
Copy link
Contributor

bors commented Oct 6, 2017

📌 Commit 6482ee7 has been approved by BurntSushi

@bors
Copy link
Contributor

bors commented Oct 7, 2017

⌛ Testing commit 6482ee7 with merge bb4d149...

bors added a commit that referenced this pull request Oct 7, 2017
Fix TcpStream::local_addr docs example code

The local address's port is not 8080 in this example, that's the remote peer address port. On my machine, the local address is different every time, so I've changed `assert_eq` to only test the IP address
@bors
Copy link
Contributor

bors commented Oct 7, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: BurntSushi
Pushing bb4d149 to master...

@bors bors merged commit 6482ee7 into rust-lang:master Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants