Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zircon: the type of zx_handle_t is now unsigned #45030

Merged
merged 2 commits into from
Oct 8, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/libstd/sys/unix/process/zircon.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,16 @@ use u64;

use libc::{c_int, c_void};

pub type zx_handle_t = i32;
pub type zx_handle_t = u32;
pub type zx_vaddr_t = usize;
pub type zx_rights_t = u32;
pub type zx_status_t = i32;

// TODO(raggi): zx_size_t was removed from Zircon. various syscall API docs use size_t here, but
// don't define that well at the ABI level yet, as the C spec definition of size_t isn't what is
// meant. In the future Zirocn will define size_t more strictly for it's ABI. At that time,
Copy link
Member

@cramertj cramertj Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Zircon, its 😄

// zx_size_t should be removed here, and replaced with an appropriately sized type with a
// sufficiently strict definition.
pub type zx_size_t = usize;

pub const ZX_HANDLE_INVALID: zx_handle_t = 0;
Expand Down