Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Don't create empty codegen units #45035

Merged
merged 1 commit into from
Oct 9, 2017
Merged

Conversation

alexcrichton
Copy link
Member

This'll end up just creating a bunch of object files that otherwise wouldn't
exist, so skip that extra work if possible.

This'll end up just creating a bunch of object files that otherwise wouldn't
exist, so skip that extra work if possible.
@alexcrichton
Copy link
Member Author

r? @michaelwoerister

@michaelwoerister
Copy link
Member

@bors r+

Yes, I don't think there's a reason to do this anymore (and there never might have been one except for the pre-existing assertions). Thanks, Alex!

@bors
Copy link
Contributor

bors commented Oct 5, 2017

📌 Commit a70c5cb has been approved by michaelwoerister

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 6, 2017
@bors
Copy link
Contributor

bors commented Oct 9, 2017

⌛ Testing commit a70c5cb with merge dbed066...

bors added a commit that referenced this pull request Oct 9, 2017
rustc: Don't create empty codegen units

This'll end up just creating a bunch of object files that otherwise wouldn't
exist, so skip that extra work if possible.
@bors
Copy link
Contributor

bors commented Oct 9, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing dbed066 to master...

@bors bors merged commit a70c5cb into rust-lang:master Oct 9, 2017
@alexcrichton alexcrichton deleted the no-empty branch October 10, 2017 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants