Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo, per #45057. #45058

Merged
merged 1 commit into from
Oct 8, 2017
Merged

Fix typo, per #45057. #45058

merged 1 commit into from
Oct 8, 2017

Conversation

hunteke
Copy link

@hunteke hunteke commented Oct 6, 2017

This looks like a simple string -- one character -- fix. Given that I'm currently running low on battery, I have not actually compiled and tested this. But I am fully confident this passes muster. If not, I'll be maintainer-educated, yes? ;-)

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@shepmaster
Copy link
Member

Thanks for your first Rust PR, @hunteke!

@shepmaster
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 6, 2017

📌 Commit 73ca15c has been approved by shepmaster

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 6, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Oct 8, 2017
@kennytm
Rollup merge of rust-lang#45058 - hunteke:fix_rustc_private_typo_2017…
ae54d5e 
…Oct, r=shepmaster

Fix typo, per rust-lang#45057.

This looks like a simple string -- one character -- fix.  Given that I'm currently running low on battery, I have not actually compiled and tested this.  But I am fully confident this passes muster.  If not, I'll be maintainer-educated, yes?  ;-)
@kennytm kennytm mentioned this pull request Oct 8, 2017
Merged
bors added a commit that referenced this pull request Oct 8, 2017
@bors
Auto merge of #45100 - kennytm:rollup, r=kennytm
f338dba 
Rollup of 10 pull requests

- Successful merges: #45018, #45042, #45052, #45053, #45058, #45060, #45081, #45083, #45090, #45094
- Failed merges:
@bors
Copy link
Contributor

bors commented Oct 8, 2017

☔ The latest upstream changes (presumably #45100) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit 73ca15c into rust-lang:master Oct 8, 2017
@hunteke hunteke deleted the fix_rustc_private_typo_2017Oct branch October 8, 2017 21:41
@estebank estebank mentioned this pull request Oct 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hunteke @rust-highfive @shepmaster @bors @nikomatsakis