clean up tempfile module and rm FIXME #4506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the FIXME suggesting that mkdtemp should rely on the default umask, because that would make it unusable for making a secure work area in a world writable directory (have to assume that other users have created files, directories, hard links, etc. in your directory). The POSIX mkdtemp function creates a directory with 700 permissions to avoid this problem.
catamorphism
added a commit
that referenced
this pull request
Jan 20, 2013
clean up tempfile module and rm FIXME
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't really think of a use case for a randomized directory name which other users have read/write permissions on. If there is some edge case, it can be dealt with by doing a chmod after the fact (but you can't do the security retroactively).
Closes #2349.