address more FIXME whose associated issues were marked as closed #45097

nivkner · 2017-10-07T21:35:55Z

update FIXME(rust-lang#6298) to point to open issue 15020 update FIXME(rust-lang#6268) to point to RFC 811 update FIXME(rust-lang#10520) to point to RFC 1751 remove FIXME for emscripten issue 4563 and include target in `test_estimate_scaling_factor` remove FIXME(rust-lang#18207) since node_id isn't used for `ref` pattern analysis remove FIXME(rust-lang#6308) since DST was implemented in rust-lang#12938 remove FIXME(rust-lang#2658) since it was decided to not reorganize module remove FIXME(rust-lang#20590) since it was decided to stay conservative with projection types remove FIXME(rust-lang#20297) since it was decided that solving the issue is unnecessary remove FIXME(rust-lang#27086) since closures do correspond to structs now remove FIXME(rust-lang#13846) and enable `function_sections` for windows remove mention of rust-lang#22079 in FIXME(rust-lang#22079) since this is a general FIXME remove FIXME(rust-lang#5074) since the restriction on borrow were lifted

rust-highfive · 2017-10-07T21:36:07Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

shepmaster · 2017-10-15T15:44:32Z

ping @rust-lang/compiler — no word from @pnkfelix in 8 days. I'm going to reassign to...

r? @estebank

estebank

r=me once the review comments are addressed.

estebank · 2017-10-16T09:51:56Z

src/librustc_back/target/windows_base.rs

@@ -64,8 +64,7 @@ pub fn opts() -> TargetOptions {
    ]);

    TargetOptions {
-        // FIXME(#13846) this should be enabled for windows
-        function_sections: false,
+        function_sections: true,


Is this supposed to be changed to true?

Yes, I tested this locally and it links successfully with x86_64-pc-windows-gnu. The FIXME was about turning on the flag once it is no longer an issue.

estebank · 2017-10-16T09:56:39Z

src/librustc_borrowck/borrowck/README.md

@@ -781,8 +781,9 @@ the base path, it will still be considered freezable.



-**FIXME #10520: Restrictions against mutating the base pointer.** When
-an `&mut` pointer is frozen or claimed, we currently pass along the
+**FIXME(https://github.com/rust-lang/rfcs/issues/1751)


Given this is md, should this be a link?

**FIXME [rfcs/1751](https://github.com/rust-lang/rfcs/issues/1751)

estebank · 2017-10-16T09:57:10Z

src/librustc_borrowck/borrowck/check_loans.rs

@@ -659,7 +659,7 @@ impl<'a, 'tcx> CheckLoanCtxt<'a, 'tcx> {
        debug!("check_if_path_is_moved(id={:?}, use_kind={:?}, lp={:?})",
               id, use_kind, lp);

-        // FIXME (22079): if you find yourself tempted to cut and paste


This points to a PR, not an issue. It's fine to remove as you're doing, just pointing it out.

I know, it's just that the FIXME is general and the number makes it seem like it is waiting on problem to be fixed.

nivkner · 2017-10-16T14:29:51Z

r=@estebank

kennytm · 2017-10-16T14:40:16Z

@bors r=estebank

bors · 2017-10-16T14:40:18Z

📌 Commit 90f6bc0 has been approved by estebank

bors · 2017-10-16T14:45:32Z

⌛ Testing commit 90f6bc0 with merge 0a2b5c7bdddcdcfda10e07f4748ebab37b60aa6c...

bors · 2017-10-16T16:02:39Z

💔 Test failed - status-appveyor

kennytm · 2017-10-16T17:48:02Z

x86_64-pc-windows-gnu, many compile-fail tests failed with error code 3780268884 (0xe1525354). Are you sure that function_sections field can be set to true?

---- [compile-fail] compile-fail\type_length_limit.rs stdout ----
	
error: failure produced the wrong error: exit code: 3780268884
status: exit code: 3780268884
command: PATH="C:\projects\rust\build\x86_64-pc-windows-gnu\stage2\bin;C:\projects\rust\build\x86_64-pc-windows-gnu\stage0-tools\x86_64-pc-windows-gnu\release\deps;C:\projects\rust\build\x86_64-pc-windows-gnu\stage0-sysroot\lib\rustlib\x86_64-pc-windows-gnu\lib;C:\Program Files (x86)\Inno Setup 5;C:\Python27;C:\projects\rust\mingw64\bin;C:\msys64\usr\bin;C:\Perl\site\bin;C:\Perl\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Program Files\7-Zip;C:\Program Files\Microsoft\Web Platform Installer;C:\Tools\GitVersion;C:\Tools\PsTools;C:\Program Files\Git LFS;C:\Program Files (x86)\Subversion\bin;C:\Program Files\Microsoft SQL Server\120\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\110\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\Binn;C:\Program Files\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\Binn\ManagementStudio;C:\Tools\WebDriver;C:\Program Files (x86)\Microsoft SDKs\TypeScript\1.4;C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\IDE\PrivateAssemblies;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI\wbin;C:\Ruby193\bin;C:\Tools\NUnit\bin;C:\Tools\xUnit;C:\Tools\MSpec;C:\Tools\Coverity\bin;C:\Program Files (x86)\CMake\bin;C:\go\bin;C:\Program Files\Java\jdk1.8.0\bin;C:\Python27;C:\Program Files\nodejs;C:\Program Files (x86)\iojs;C:\Program Files\iojs;C:\Users\appveyor\AppData\Roaming\npm;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files (x86)\MSBuild\14.0\Bin;C:\Tools\NuGet;C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program Files\Microsoft DNX\Dnvm;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\130\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Apache\Maven\bin;C:\Python27\Scripts;C:\Tools\NUnit3;C:\Program Files\Mercurial;C:\Program Files\LLVM\bin;C:\Program Files\dotnet;C:\Program Files\erl8.3\bin;C:\Tools\curl\bin;C:\Program Files\Amazon\AWSCLI;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\Extensions\Microsoft\SQLDB\DAC\140;C:\Program Files (x86)\Yarn\bin;C:\Program Files\Git\cmd;C:\Program Files\Git\usr\bin;C:\ProgramData\chocolatey\bin;C:\Tools\vcpkg;C:\Program Files (x86)\nodejs;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Users\appveyor\AppData\Local\Yarn\bin;C:\Users\appveyor\AppData\Roaming\npm;C:\Program Files\AppVeyor\BuildAgent;C:\projects\rust;C:\projects\rust\handle" "C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "C:\\projects\\rust\\src/test\\compile-fail\\type_length_limit.rs" "-L" "C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\test\\compile-fail" "--target=x86_64-pc-windows-gnu" "-C" "prefer-dynamic" "-o" "C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\test\\compile-fail\\type_length_limit.stage2-x86_64-pc-windows-gnu.exe" "-Crpath" "-O" "-Lnative=C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\native\\rust-test-helpers" "-L" "C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\test\\compile-fail\\type_length_limit.stage2-x86_64-pc-windows-gnu.compile-fail.libaux" "-A" "unused"
stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
error: reached the type-length limit while instantiating `std::mem::drop::<std::option::Option<((((((G, G, G), (G, G, G), ...`
  |
  = note: consider adding a `#![type_length_limit="512"]` attribute to your crate
error: aborting due to previous error
------------------------------------------
thread '[compile-fail] compile-fail\type_length_limit.rs' panicked at 'explicit panic', src\tools\compiletest\src\runtest.rs:2478:8
failures:
    [compile-fail] compile-fail\E0275.rs
    [compile-fail] compile-fail\E0404.rs
    [compile-fail] compile-fail\E0405.rs
    [compile-fail] compile-fail\bad-lint-cap.rs
    [compile-fail] compile-fail\cdylib-deps-must-be-static.rs
    [compile-fail] compile-fail\cfg-arg-invalid.rs
    [compile-fail] compile-fail\cfg-empty-codemap.rs
    [compile-fail] compile-fail\coherence-inherited-assoc-ty-cycle-err.rs
    [compile-fail] compile-fail\const-size_of-cycle.rs
    [compile-fail] compile-fail\dupe-symbols-1.rs
    [compile-fail] compile-fail\dupe-symbols-2.rs
    [compile-fail] compile-fail\dupe-symbols-3.rs
    [compile-fail] compile-fail\dupe-symbols-4.rs
    [compile-fail] compile-fail\dupe-symbols-5.rs
    [compile-fail] compile-fail\dupe-symbols-6.rs
    [compile-fail] compile-fail\dupe-symbols-7.rs
    [compile-fail] compile-fail\extern-with-type-bounds.rs
    [compile-fail] compile-fail\huge-array.rs
    [compile-fail] compile-fail\huge-enum.rs
    [compile-fail] compile-fail\huge-struct.rs
    [compile-fail] compile-fail\impl-trait\auto-trait-leak.rs
    [compile-fail] compile-fail\import-loop-2.rs
    [compile-fail] compile-fail\infinite-instantiation.rs
    [compile-fail] compile-fail\inhabitedness-infinite-loop.rs
    [compile-fail] compile-fail\issue-15919.rs
    [compile-fail] compile-fail\issue-17913.rs
    [compile-fail] compile-fail\issue-17999.rs
    [compile-fail] compile-fail\issue-18400.rs
    [compile-fail] compile-fail\issue-19660.rs
    [compile-fail] compile-fail\issue-20413.rs
    [compile-fail] compile-fail\issue-21946.rs
    [compile-fail] compile-fail\issue-22599.rs
    [compile-fail] compile-fail\issue-22638.rs
    [compile-fail] compile-fail\issue-23122-1.rs
    [compile-fail] compile-fail\issue-23122-2.rs
    [compile-fail] compile-fail\issue-2330.rs
    [compile-fail] compile-fail\issue-31109.rs
    [compile-fail] compile-fail\issue-31495.rs
    [compile-fail] compile-fail\issue-8727.rs
    [compile-fail] compile-fail\lang-item-missing.rs
    [compile-fail] compile-fail\linkage2.rs
    [compile-fail] compile-fail\linkage3.rs
    [compile-fail] compile-fail\lint-removed-allow.rs
    [compile-fail] compile-fail\lint-removed-cmdline.rs
    [compile-fail] compile-fail\lint-removed.rs
    [compile-fail] compile-fail\lint-renamed-allow.rs
    [compile-fail] compile-fail\lint-renamed-cmdline.rs
    [compile-fail] compile-fail\lint-renamed.rs
    [compile-fail] compile-fail\lint-unknown-lint.rs
    [compile-fail] compile-fail\liveness-dead.rs
    [compile-fail] compile-fail\liveness-unused.rs
    [compile-fail] compile-fail\main-wrong-location.rs
    [compile-fail] compile-fail\manual-link-bad-kind.rs
    [compile-fail] compile-fail\manual-link-bad-search-path.rs
    [compile-fail] compile-fail\mir-dataflow\def-inits-1.rs
    [compile-fail] compile-fail\mir-dataflow\inits-1.rs
    [compile-fail] compile-fail\mir-dataflow\uninits-1.rs
    [compile-fail] compile-fail\mir-dataflow\uninits-2.rs
    [compile-fail] compile-fail\no-implicit-prelude-nested.rs
    [compile-fail] compile-fail\no-implicit-prelude.rs
    [compile-fail] compile-fail\no_owned_box_lang_item.rs
    [compile-fail] compile-fail\panic-runtime\abort-link-to-unwind-dylib.rs
    [compile-fail] compile-fail\panic-runtime\bad-panic-flag1.rs
    [compile-fail] compile-fail\panic-runtime\bad-panic-flag2.rs
    [compile-fail] compile-fail\panic-runtime\libtest-unwinds.rs
    [compile-fail] compile-fail\panic-runtime\transitive-link-a-bunch.rs
    [compile-fail] compile-fail\panic-runtime\two-panic-runtimes.rs
    [compile-fail] compile-fail\panic-runtime\want-abort-got-unwind.rs
    [compile-fail] compile-fail\panic-runtime\want-abort-got-unwind2.rs
    [compile-fail] compile-fail\panic-runtime\want-unwind-got-abort.rs
    [compile-fail] compile-fail\panic-runtime\want-unwind-got-abort2.rs
    [compile-fail] compile-fail\privacy2.rs
    [compile-fail] compile-fail\privacy3.rs
    [compile-fail] compile-fail\recursion.rs
    [compile-fail] compile-fail\required-lang-item.rs
    [compile-fail] compile-fail\resolve-self-in-impl-2.rs
    [compile-fail] compile-fail\resolve-unknown-trait.rs
    [compile-fail] compile-fail\rmeta_lib.rs
    [compile-fail] compile-fail\simd-type-generic-monomorphisation.rs
    [compile-fail] compile-fail\trait-bounds-not-on-struct.rs
    [compile-fail] compile-fail\trait-test.rs
    [compile-fail] compile-fail\traits-inductive-overflow-simultaneous.rs
    [compile-fail] compile-fail\traits-inductive-overflow-supertrait.rs
    [compile-fail] compile-fail\traits-inductive-overflow-two-traits.rs
    [compile-fail] compile-fail\type_length_limit.rs
test result: FAILED. 2679 passed; 85 failed; 14 ignored; 0 measured; 0 filtered out

nivkner · 2017-10-16T19:57:42Z

guess not, didn't test thoroughly enough. Reverted change

estebank · 2017-10-17T09:54:17Z

@bors r+ rollup

bors · 2017-10-17T09:54:18Z

📌 Commit 094c2ae has been approved by estebank

address more FIXME whose associated issues were marked as closed part of rust-lang#44366

Rollup of 10 pull requests - Successful merges: #45097, #45151, #45307, #45308, #45310, #45315, #45321, #45329, #45338, #45339 - Failed merges:

rust-highfive assigned pnkfelix Oct 7, 2017

carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2017

shepmaster added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 15, 2017

rust-highfive assigned estebank and unassigned pnkfelix Oct 15, 2017

estebank approved these changes Oct 16, 2017

View reviewed changes

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2017

turn link to RFC 1751 into a markdown link

90f6bc0

kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 16, 2017

revert change to function_sections for windows

094c2ae

nivkner force-pushed the fixme_fixup2 branch from 3b0cd94 to 094c2ae Compare October 16, 2017 19:59

kennytm mentioned this pull request Oct 17, 2017

Rollup of 10 pull requests #45344

Merged

kennytm added a commit to kennytm/rust that referenced this pull request Oct 17, 2017

Rollup merge of rust-lang#45097 - nivkner:fixme_fixup2, r=estebank

40d61f5

address more FIXME whose associated issues were marked as closed part of rust-lang#44366

bors added a commit that referenced this pull request Oct 17, 2017

Auto merge of #45344 - kennytm:rollup, r=kennytm

f6d7514

Rollup of 10 pull requests - Successful merges: #45097, #45151, #45307, #45308, #45310, #45315, #45321, #45329, #45338, #45339 - Failed merges:

bors merged commit 094c2ae into rust-lang:master Oct 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

address more FIXME whose associated issues were marked as closed #45097

address more FIXME whose associated issues were marked as closed #45097

nivkner commented Oct 7, 2017

rust-highfive commented Oct 7, 2017

shepmaster commented Oct 15, 2017

estebank left a comment

estebank Oct 16, 2017

nivkner Oct 16, 2017

estebank Oct 16, 2017

estebank Oct 16, 2017

nivkner Oct 16, 2017

nivkner commented Oct 16, 2017

kennytm commented Oct 16, 2017

bors commented Oct 16, 2017

bors commented Oct 16, 2017

bors commented Oct 16, 2017

kennytm commented Oct 16, 2017 •

edited

Loading

nivkner commented Oct 16, 2017

estebank commented Oct 17, 2017

bors commented Oct 17, 2017

address more FIXME whose associated issues were marked as closed #45097

address more FIXME whose associated issues were marked as closed #45097

Conversation

nivkner commented Oct 7, 2017

rust-highfive commented Oct 7, 2017

shepmaster commented Oct 15, 2017

estebank left a comment

Choose a reason for hiding this comment

estebank Oct 16, 2017

Choose a reason for hiding this comment

nivkner Oct 16, 2017

Choose a reason for hiding this comment

estebank Oct 16, 2017

Choose a reason for hiding this comment

estebank Oct 16, 2017

Choose a reason for hiding this comment

nivkner Oct 16, 2017

Choose a reason for hiding this comment

nivkner commented Oct 16, 2017

kennytm commented Oct 16, 2017

bors commented Oct 16, 2017

bors commented Oct 16, 2017

bors commented Oct 16, 2017

kennytm commented Oct 16, 2017 • edited Loading

nivkner commented Oct 16, 2017

estebank commented Oct 17, 2017

bors commented Oct 17, 2017

kennytm commented Oct 16, 2017 •

edited

Loading