Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explanatory text for error E0599 #45356

Merged
merged 1 commit into from
Oct 21, 2017
Merged

Add explanatory text for error E0599 #45356

merged 1 commit into from
Oct 21, 2017

Conversation

neunenak
Copy link
Contributor

Add a text description of this error instead of just example error code

r? GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2017
@neunenak
Copy link
Contributor Author

I think I was supposed to mention @GuillaumeGomez specifically and messed up the notification syntax, sorry about that.

GuillaumeGomez
GuillaumeGomez reviewed Oct 20, 2017
View reviewed changes
src/librustc_typeck/diagnostics.rs Outdated
@@ -3986,6 +3986,9 @@ details.
"##,

E0599: r##"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line.

GuillaumeGomez
GuillaumeGomez reviewed Oct 20, 2017
View reviewed changes
src/librustc_typeck/diagnostics.rs Outdated
@@ -3986,6 +3986,9 @@ details.
"##,

E0599: r##"

This error occurs when a method is used on a type which doesn't implement it:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this to:

This error occurs when a method is used on a type which doesn't implement it.

Erroneous code example:

@GuillaumeGomez
Copy link
Member

Once updated, it's good to go. Thanks!

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2017
@neunenak
Add explanatory text for error E0599
23bf330 
Add a text description of this error instead of just example error code
@neunenak
Copy link
Contributor Author

Updated this commit per comments.

@kennytm
Copy link
Member

kennytm commented Oct 21, 2017

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Oct 21, 2017

📌 Commit 23bf330 has been approved by GuillaumeGomez

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 21, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Oct 21, 2017
@frewsxcv
Rollup merge of rust-lang#45356 - neunenak:master, r=GuillaumeGomez
22e808a 
Add explanatory text for error E0599

Add a text description of this error instead of just example error code

r? GuillaumeGomez
@frewsxcv frewsxcv mentioned this pull request Oct 21, 2017
Merged
bors added a commit that referenced this pull request Oct 21, 2017
@bors
Auto merge of #45430 - frewsxcv:rollup, r=frewsxcv
7e70546 
Rollup of 6 pull requests

- Successful merges: #45227, #45356, #45407, #45411, #45418, #45419
- Failed merges: #45421
@bors bors merged commit 23bf330 into rust-lang:master Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

Assignees

@arielb1 arielb1

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@neunenak @rust-highfive @GuillaumeGomez @kennytm @bors @arielb1