Skip to content

Correct misspelling in error text: re-assignment => reassignment #45398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/librustc_borrowck/borrowck/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,7 @@ impl<'a, 'tcx> BorrowckCtxt<'a, 'tcx> {
let mut err = self.cannot_reassign_immutable(span,
&self.loan_path_to_string(lp),
Origin::Ast);
err.span_label(span, "re-assignment of immutable variable");
err.span_label(span, "cannot assign twice to immutable variable");
if span != assign.span {
err.span_label(assign.span, format!("first assignment to `{}`",
self.loan_path_to_string(lp)));
Expand Down
2 changes: 1 addition & 1 deletion src/librustc_mir/borrow_check.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1161,7 +1161,7 @@ impl<'c, 'b, 'a: 'b+'c, 'gcx, 'tcx: 'a> MirBorrowckCtxt<'c, 'b, 'a, 'gcx, 'tcx>
self.tcx.cannot_reassign_immutable(span,
&self.describe_lvalue(lvalue),
Origin::Mir)
.span_label(span, "re-assignment of immutable variable")
.span_label(span, "cannot assign twice to immutable variable")
.span_label(assigned_span, format!("first assignment to `{}`",
self.describe_lvalue(lvalue)))
.emit();
Expand Down
2 changes: 1 addition & 1 deletion src/librustc_mir/util/borrowck_errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ pub trait BorrowckErrors {
-> DiagnosticBuilder
{
struct_span_err!(self, span, E0384,
"re-assignment of immutable variable `{}`{OGN}",
"cannot assign twice to immutable variable `{}`{OGN}",
desc, OGN=o)
}

Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/asm-out-assign-imm.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ pub fn main() {
foo(x);
unsafe {
asm!("mov $1, $0" : "=r"(x) : "r"(5));
//~^ ERROR re-assignment of immutable variable `x`
//~| NOTE re-assignment of immutable
//~^ ERROR cannot assign twice to immutable variable `x`
//~| NOTE cannot assign twice to immutable
}
foo(x);
}
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/assign-imm-local-twice.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ fn test() {
let v: isize;
v = 1; //~ NOTE first assignment
println!("v={}", v);
v = 2; //~ ERROR re-assignment of immutable variable
//~| NOTE re-assignment of immutable
v = 2; //~ ERROR cannot assign twice to immutable variable
//~| NOTE cannot assign twice to immutable
println!("v={}", v);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,39 +26,39 @@ struct S {
pub fn main() {
match 1 {
x => {
x += 1; //[ast]~ ERROR re-assignment of immutable variable `x`
x += 1; //[ast]~ ERROR cannot assign twice to immutable variable `x`
//[mir]~^ ERROR (Mir) [E0384]
//[mir]~| ERROR (Ast) [E0384]
}
}

match E::Foo(1) {
E::Foo(x) => {
x += 1; //[ast]~ ERROR re-assignment of immutable variable `x`
x += 1; //[ast]~ ERROR cannot assign twice to immutable variable `x`
//[mir]~^ ERROR (Mir) [E0384]
//[mir]~| ERROR (Ast) [E0384]
}
}

match (S { bar: 1 }) {
S { bar: x } => {
x += 1; //[ast]~ ERROR re-assignment of immutable variable `x`
x += 1; //[ast]~ ERROR cannot assign twice to immutable variable `x`
//[mir]~^ ERROR (Mir) [E0384]
//[mir]~| ERROR (Ast) [E0384]
}
}

match (1,) {
(x,) => {
x += 1; //[ast]~ ERROR re-assignment of immutable variable `x`
x += 1; //[ast]~ ERROR cannot assign twice to immutable variable `x`
//[mir]~^ ERROR (Mir) [E0384]
//[mir]~| ERROR (Ast) [E0384]
}
}

match [1,2,3] {
[x,_,_] => {
x += 1; //[ast]~ ERROR re-assignment of immutable variable `x`
x += 1; //[ast]~ ERROR cannot assign twice to immutable variable `x`
//[mir]~^ ERROR (Mir) [E0384]
//[mir]~| ERROR (Ast) [E0384]
}
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/liveness-assign-imm-local-in-loop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
fn test() {
let v: isize;
loop {
v = 1; //~ ERROR re-assignment of immutable variable
//~^ NOTE re-assignment of immutable variable
v = 1; //~ ERROR cannot assign twice to immutable variable
//~^ NOTE cannot assign twice to immutable variable
v.clone(); // just to prevent liveness warnings
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/liveness-assign-imm-local-in-op-eq.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
fn test() {
let v: isize;
v = 2; //~ NOTE first assignment
v += 1; //~ ERROR re-assignment of immutable variable
//~| NOTE re-assignment of immutable
v += 1; //~ ERROR cannot assign twice to immutable variable
//~| NOTE cannot assign twice to immutable
v.clone();
}

Expand Down
4 changes: 2 additions & 2 deletions src/test/compile-fail/liveness-assign-imm-local-with-init.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
fn test() {
let v: isize = 1; //~ NOTE first assignment
v.clone();
v = 2; //~ ERROR re-assignment of immutable variable
//~| NOTE re-assignment of immutable
v = 2; //~ ERROR cannot assign twice to immutable variable
//~| NOTE cannot assign twice to immutable
v.clone();
}

Expand Down
6 changes: 3 additions & 3 deletions src/test/compile-fail/mut-pattern-internal-mutability.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ fn main() {
let foo = &mut 1;

let &mut x = foo;
x += 1; //[ast]~ ERROR re-assignment of immutable variable
//[mir]~^ ERROR re-assignment of immutable variable `x` (Ast)
//[mir]~| ERROR re-assignment of immutable variable `x` (Mir)
x += 1; //[ast]~ ERROR cannot assign twice to immutable variable
//[mir]~^ ERROR cannot assign twice to immutable variable `x` (Ast)
//[mir]~| ERROR cannot assign twice to immutable variable `x` (Mir)

// explicitly mut-ify internals
let &mut mut x = foo;
Expand Down