add graphvis DOT files to dump mir directory #45497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
the
S-waiting-on-review
nikomatsakis
requested changes
Oct 25, 2017
src/librustc/session/config.rs
Outdated
| @@ -1057,6 +1057,8 @@ options! {DebuggingOptions, DebuggingSetter, basic_debugging_options, | |||
| "dump MIR state at various points in translation"), | |||
| dump_mir_dir: Option<String> = (None, parse_opt_string, [UNTRACKED], | |||
| "the directory the MIR is dumped into"), | |||
| dump_mir_graphviz: bool = (false, parse_bool, [UNTRACKED], | |||
| "additionally to MIR create graphviz DOT files"), | |||
There was a problem hiding this comment.
Maybe: when dumping MIR, also create graphviz-style .dot files
|
Looks good! Left a small comment. |
mikhail-m1
force-pushed
the
dump-mir-graphviz
branch
from
e87bcb2 to
08b1fe3
Compare
|
@nikomatsakis The current wording is
is it good enough for an r=? |
"in addition to" sounds better than "additionally to"
nikomatsakis
approved these changes
Oct 30, 2017
|
@bors r+ |
|
📌 Commit b2c2ba4 has been approved by |
kennytm
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 30, 2017
add graphvis DOT files to dump mir directory r? @nikomatsakis
|
💔 Test failed - status-travis |
|
@bors retry
|
bors
added a commit
that referenced
this pull request
Oct 30, 2017
add graphvis DOT files to dump mir directory r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis