Return 0 as an exit status when no subcommand is given to bootstrap #45535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
added
S-waiting-on-review
topecongiro
force-pushed
the
bootstrap-exit-code
branch
from
5fefa01 to
fa2bc78
Compare
|
@kennytm Thank you for the review! I updated the PR so that |
kennytm
approved these changes
Oct 26, 2017
kennytm
added
S-waiting-on-review
kennytm
approved these changes
Oct 26, 2017
src/bootstrap/flags.rs
Outdated
| @@ -136,9 +136,12 @@ To learn more about a subcommand, run `./x.py <subcommand> -h`"); | |||
| let subcommand = match subcommand { | |||
| Some(s) => s, | |||
| None => { | |||
| // No subcommand -- show the general usage and subcommand help | |||
| // No or an invlaid subcommand -- show the general usage and subcommand help | |||
topecongiro
force-pushed
the
bootstrap-exit-code
branch
from
fa2bc78 to
732d9b2
Compare
|
@kennytm Thanks again, fixed a typo and rebased. |
|
@bors r+ rollup Thanks! |
|
📌 Commit 732d9b2 has been approved by |
kennytm
added
S-waiting-on-bors
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Oct 28, 2017
…kennytm
Return 0 as an exit status when no subcommand is given to bootstrap
Running `./x.py` emits usage and error messages when no subcommand is given:
```
Usage: x.py <subcommand> [options] [<paths>...]
Subcommands:
build Compile either the compiler or libraries
test Build and run some test suites
bench Build and run some benchmarks
doc Build documentation
clean Clean out build directories
dist Build distribution artifacts
install Install distribution artifacts
To learn more about a subcommand, run `./x.py <subcommand> -h`
failed to run: /home/topecongiro/rust/build/bootstrap/debug/bootstrap
```
IMHO the last line is unnecessary. This PR removes it by changing the return code of `bootstrap` to 0 when no sub command is given.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 28, 2017
…kennytm
Return 0 as an exit status when no subcommand is given to bootstrap
Running `./x.py` emits usage and error messages when no subcommand is given:
```
Usage: x.py <subcommand> [options] [<paths>...]
Subcommands:
build Compile either the compiler or libraries
test Build and run some test suites
bench Build and run some benchmarks
doc Build documentation
clean Clean out build directories
dist Build distribution artifacts
install Install distribution artifacts
To learn more about a subcommand, run `./x.py <subcommand> -h`
failed to run: /home/topecongiro/rust/build/bootstrap/debug/bootstrap
```
IMHO the last line is unnecessary. This PR removes it by changing the return code of `bootstrap` to 0 when no sub command is given.
bors
added a commit
that referenced
this pull request
Oct 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
./x.pyemits usage and error messages when no subcommand is given:IMHO the last line is unnecessary. This PR removes it by changing the return code of
bootstrapto 0 when no sub command is given.