Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsyntax_pos: Don't use packed attribute for Span on sparc64/v9 #45679

Closed
wants to merge 1 commit into from
Closed

libsyntax_pos: Don't use packed attribute for Span on sparc64/v9 #45679

wants to merge 1 commit into from

Commits on Nov 1, 2017

  1. libsyntax_pos: Don't use packed attribute for Span on sparc64/v9 

    Due the limitation that #[derive(...)] on #[repr(packed)] structs
does not guarantee proper alignment of the compiler-generated
impls is not guaranteed (rust-lang#39696), the change in rust-lang#44646 to compress
Spans results in the compiler generating code with unaligned access.

Until rust-lang#39696 has been fixed, the issue can be worked around by
not using the packed attribute on sparc64 and sparcv9 on the
Span struct.

Fixes: rust-lang#45509
    @glaubitz
    glaubitz committed Nov 1, 2017
    Configuration menu
    Copy the full SHA
    d4745f8 View commit details
    Browse the repository at this point in the history