Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cargo submodule #45813

Closed
wants to merge 1 commit into from
Closed

Update Cargo submodule #45813

wants to merge 1 commit into from

Conversation

alexcrichton
Copy link
Member

This notably brings in rust-lang/cargo#4646 which should help debugging a few
issues and getting it out there for testing sooner.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @kennytm

@rust-highfive rust-highfive assigned kennytm and unassigned aturon Nov 6, 2017
@bors
Copy link
Contributor

bors commented Nov 6, 2017

☔ The latest upstream changes (presumably #45811) made this pull request unmergeable. Please resolve the merge conflicts.

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 7, 2017
@kennytm
Copy link
Member

kennytm commented Nov 7, 2017

r=me after fixing merge conflict.

@alexcrichton
Update Cargo submodule
28ed5bd 
This notably brings in rust-lang/cargo#4646 which should help debugging a few
issues and getting it out there for testing sooner.
@alexcrichton
Copy link
Member Author

@bors: r=kennytm

@bors
Copy link
Contributor

bors commented Nov 7, 2017

📌 Commit 28ed5bd has been approved by kennytm

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 7, 2017
@bors
Copy link
Contributor

bors commented Nov 12, 2017

⌛ Testing commit 28ed5bd with merge 27e9cc860cd66a31819f0b6afd4c3082b6148c5a...

@bors
Copy link
Contributor

bors commented Nov 12, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Nov 12, 2017

dist-x86_64-freebsd and -netbsd, same error as #45692.

Since #45692 also updates the cargo sub module, maybe we could close this?

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 12, 2017
@alexcrichton alexcrichton deleted the update-cargo branch November 12, 2017 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @rust-highfive @bors @kennytm @aturon