Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic Associated Types Parsing & Name Resolution #45904

Merged
merged 19 commits into from
Dec 2, 2017
Merged

Generic Associated Types Parsing & Name Resolution #45904

merged 19 commits into from
Dec 2, 2017

Commits on Dec 1, 2017

  1. Parsing generics in both trait items and impl items

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    19e25b6 View commit details
    Browse the repository at this point in the history

  2. Added run-pass tests for associated generic types

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    6bd8ea1 View commit details
    Browse the repository at this point in the history

  3. Adding feature gate

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    f296134 View commit details
    Browse the repository at this point in the history

  4. Fixed tidy errors

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    83efebc View commit details
    Browse the repository at this point in the history

  5. More testing for generic associated types parsing

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    332a3cb View commit details
    Browse the repository at this point in the history

  6. Added stderr files for ui tests

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    1b196fa View commit details
    Browse the repository at this point in the history

  7. demonstrate how we can write "successful parse" tests quite easily

    @nikomatsakis @sunjay
    nikomatsakis authored and sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    e565b5b View commit details
    Browse the repository at this point in the history

  8. Specifically gating generic_associated_types feature on associated Ty… 

    …pe declarations
    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    c2aaba9 View commit details
    Browse the repository at this point in the history

  9. Parsing where clauses correctly and documenting the grammar being parsed

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    223d091 View commit details
    Browse the repository at this point in the history

  10. Preventing moving out of the trait item kind

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    4a69ce9 View commit details
    Browse the repository at this point in the history

  11. Adding type paramter ribs for generic associated types

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    e0621a1 View commit details
    Browse the repository at this point in the history

  12. Renaming MethodRibKind to TraitOrImplItemRibKind and removing its fie… 

    …ld which was never used. Lifting the HasTypeParameters rib to all trait item kinds and all impl item kinds
    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    1c023b3 View commit details
    Browse the repository at this point in the history

  13. Testing and fixes

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    38c2a73 View commit details
    Browse the repository at this point in the history

  14. added must-compile-successfully

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    3bac9ff View commit details
    Browse the repository at this point in the history

  15. Adding error line so that test passes

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    cc52e41 View commit details
    Browse the repository at this point in the history

  16. Removed FIXME on a line that actually works for some reason...

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    db4408a View commit details
    Browse the repository at this point in the history

  17. Moved all of the tests over to ui and annotated why they are failing … 

    …with appropriate fixme comments
    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    fdf6c65 View commit details
    Browse the repository at this point in the history

  18. Added case for when impl generic associated type has a where clause

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    f0ecdfb View commit details
    Browse the repository at this point in the history

  19. Updated generic-associated-types-where stderr

    @sunjay
    sunjay committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    9d5592b View commit details
    Browse the repository at this point in the history