Rewrite the coercion code to be more readable, more sound, and to reborrow when needed. #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I think I see why the tests are passing on trunk even though I expect them to fail (or one reason, anyway)---I'm passing in the &mut by reference. I will try and correct that. Working with slices and impls still feels semi-awkward. Sigh. |
|
r+ |
contents of other borrowed pointers to the lifetimes of the borrowed value. Fixes rust-lang#3148.
The tail portion of the pattern effectively borrows a vector, but the borrow checker knew nothing about this.
for notating FIXME-style-situations that you want to be reminded of before you commit.
be necessary for reborrowing.
…orrow when needed. Regarding soundness: there was a subtle bug in how it was done before; see the compile-fail test for an example. Regarding reborrowing: reborrowing allows mut and const slices/borrowed-pointers to be used with pure fns that expect immutable data.
lent. We can be more liberal with respect to the scope of the loan if we do not own the data being lent, which used to be impossible but can now occur with `&mut`.
|
r=me |
|
Pushed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first few commits are all refactorings that should not affect anything. The last commit is the important part. There is one caveat, which is that it was a bit hard for me to test some of the method stuff: it seems to do the right thing, but the current code also passes the tests, though it shouldn't, I think due to various bugs in the mode.rs code. So I may have some more patches coming along.
r? @brson