rustbuild: Update LLVM and enable ThinLTO #46008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
@bors r+ |
|
📌 Commit bf3320f has been approved by |
kennytm
added
the
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #45897) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
force-pushed
the
update-llvm
branch
from
bf3320f
to
e18dbaa
Compare
|
@bors: r=Mark-Simulacrum |
|
📌 Commit e18dbaa has been approved by |
|
⌛ Testing commit e18dbaa64dbc63737a0abc9432cac886b89c286c with merge 557e2ccf38ae65cb1522a7c755809104cb8b18a5... |
|
💔 Test failed - status-travis |
|
|
kennytm
added
S-waiting-on-author
|
cc #44899 — This PR contains the fix for that issue as well. |
|
Looks like that was accidentally caused by rust-lang/compiler-builtins#206 |
|
in that we forgot this commit -- rust-lang/compiler-builtins@02b3734 |
alexcrichton
force-pushed
the
update-llvm
branch
from
e18dbaa
to
78e13ba
Compare
|
@bors: r=Mark-Simulacrum |
|
📌 Commit 78e13ba has been approved by |
kennytm
added
S-waiting-on-bors
|
⌛ Testing commit 78e13ba6b969cf81a331869b891abb286346d453 with merge a25d81b2707b712d6b3f6b16ad7e09bfcf995be2... |
|
💔 Test failed - status-travis |
|
@alexcrichton Given that ThinLTO also affects sanitizers (#45220), I'm not so sure it is spurious or not. Let's see what bors says. |
|
Turns out using LTO on Windows means you currently don't run any thread local destructors at all. Using ThinLTO just exposed this. Let's try again! @bors: r=Mark-Simulacrum |
|
📌 Commit 7bed281 has been approved by |
|
⌛ Testing commit 7bed281dc022806efd1104e91a727fb66470d916 with merge c7b11f98b67ce0761fcda5f77ce7b33eadddf716... |
kennytm
added
S-waiting-on-bors
|
💔 Test failed - status-travis |
kennytm
added
S-waiting-on-author
|
The Perhaps add a |
alexcrichton
force-pushed
the
update-llvm
branch
from
7bed281
to
9714458
Compare
|
@bors: r=Mark-Simulacrum |
|
📌 Commit 9714458 has been approved by |
kennytm
added
S-waiting-on-bors
|
⌛ Testing commit 9714458100b3b3e883d0814cc66b3bb53df323bf with merge 8b2526dd476884c6f2422fb3d58a2a19b0c46e1e... |
|
💔 Test failed - status-travis |
Turns out ThinLTO was internalizing this symbol and eliminating it. Worse yet if you compiled with LTO turns out no TLS destructors would run on Windows! The `#[used]` annotation should be a more bulletproof implementation (in the face of LTO) of preserving this symbol all the way through in LLVM and ensuring it makes it all the way to the linker which will take care of it.
alexcrichton
force-pushed
the
update-llvm
branch
from
9714458
to
95e9609
Compare
|
@bors: r=Mark-Simulacrum Woe unto thee who decides to add a test |
|
📌 Commit 95e9609 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 25, 2017
rustbuild: Update LLVM and enable ThinLTO This commit updates LLVM to fix #45511 (https://reviews.llvm.org/D39981) and also reenables ThinLTO for libtest now that we shouldn't hit #45768. This also opportunistically enables ThinLTO for libstd which was previously blocked (#45661) on test failures related to debuginfo with a presumed cause of #45511. Closes #45511
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates LLVM to fix #45511 (https://reviews.llvm.org/D39981) and
also reenables ThinLTO for libtest now that we shouldn't hit #45768. This also
opportunistically enables ThinLTO for libstd which was previously blocked
(#45661) on test failures related to debuginfo with a presumed cause of #45511.
Closes #45511