Rollup of 6 pull requests #46029
Merged
Rollup of 6 pull requests #46029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes macro expansion to format the path of a macro directly instead of usng the pprust infrastructure. The pprust infrastructure tries to perform line-breaking in a slow fashion, which is undesired when formatting the path of a macro. This should to speed up expansion by a fair amount (I saw 20% on a profiler on `rustc_mir`, and 50% of the time marked as "expansion" in the profiler/time-passes is actually spent loading dependencies).
Show both the attribute and the item
incr: Update hash tests to use `except`-style checking Part of rust-lang#44924 r? @michaelwoerister
avoid the pprust infrastructure in macro expansion This changes macro expansion to format the path of a macro directly instead of usng the pprust infrastructure. The pprust infrastructure tries to perform line-breaking in a slow fashion, which is undesired when formatting the path of a macro. This should to speed up expansion by a fair amount (I saw 20% on a profiler on `rustc_mir`, and 50% of the time marked as "expansion" in the profiler/time-passes is actually spent loading dependencies). r? @jseyfried
Add context to E0084, E0517, E0518 A small diagnostic enhancement to get my feet wet. Please scrutinize! This modifies errors E0084, E0517, and E0518 to include both the annotation and the annotated item. All of these errors already had labels; I moved the label to the other span, and rephrased it as necessary. Fixes rust-lang#45886
examples in Cow::into_owned don't need to wrap result in Cows This totally confused me until i triple-checked the actual return value and opened the examples in the playground myself. r? @rust-lang/docs
Set short-message feature unstable Fixes rust-lang#45995. r? @nrc
rustdoc: Escape doc root URLs This fixes a small HTML injection issue.
|
@bors: r+ p=1 |
|
📌 Commit d57fed8 has been approved by |
|
⌛ Testing commit d57fed8 with merge a6a65dd522c1d885385a14953667bb7ee1f7928a... |
|
💔 Test failed - status-travis |
|
@bors p=6 |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
except-style checking #45951, avoid the pprust infrastructure in macro expansion #45973, Add context to E0084, E0517, E0518 #45984, examples in Cow::into_owned don't need to wrap result in Cows #45993, Set short-message feature unstable #46005, rustdoc: Escape doc root URLs #46010