Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update books for next release #46110

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Conversation

steveklabnik
Copy link
Member

Since I was out last week I didn't get this done as early as usual, I don't know if beta has branched already or not.

@rust-highfive
Copy link
Collaborator

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2017
@kennytm
Copy link
Member

kennytm commented Nov 20, 2017

A lot of broken links in the reference:

[01:30:52] std/ops/index.html:67: broken link fragment `#operator-precedence` pointing to `reference/expressions/operator-expr.html`
[01:31:00] core/ops/index.html:67: broken link fragment `#operator-precedence` pointing to `reference/expressions/operator-expr.html`
[01:31:01] reference/print.html:440: broken link - reference/string-table-productions.html
[01:31:01] reference/print.html:948: broken link - reference/items/use_declarations.html
[01:31:01] reference/print.html:1870: broken link fragment `#expresions.html#constant-expressions` pointing to `reference/print.html`
[01:31:01] reference/print.html:3637: broken link - reference/destructors.hmtl
[01:31:01] reference/print.html:3931: broken link fragment `#visibility-and-privacy.html` pointing to `reference/print.html`
[01:31:01] reference/print.html:5167: broken link fragment `#struct` pointing to `reference/types.html`
[01:31:01] reference/print.html:5174: broken link fragment `#struct` pointing to `reference/types.html`
[01:31:01] reference/print.html:5174: broken link fragment `#enumeration-types` pointing to `reference/types.html`
[01:31:01] reference/expressions/method-call-expr.html:163: broken link fragment `#visibility-and-privacy.html` pointing to `reference/expressions/method-call-expr.html`
[01:31:01] reference/expressions/operator-expr.html:436: broken link - reference/destructors.hmtl
[01:31:01] reference/expressions.html:193: broken link fragment `#path-expressions` pointing to `reference/expressions.html`
[01:31:01] reference/paths.html:233: broken link - reference/items/use_declarations.html
[01:31:01] reference/tokens.html:148: broken link - reference/string-table-productions.html
[01:31:01] reference/destructors.html:150: broken link fragment `#struct` pointing to `reference/types.html`
[01:31:01] reference/destructors.html:157: broken link fragment `#struct` pointing to `reference/types.html`
[01:31:01] reference/destructors.html:157: broken link fragment `#enumeration-types` pointing to `reference/types.html`
[01:31:01] reference/items/static-items.html:161: broken link fragment `#expresions.html#constant-expressions` pointing to `reference/items/static-items.html`

Also includes a fix in std::ops
@steveklabnik
Copy link
Member Author

steveklabnik commented Nov 20, 2017

@kennytm yup, just fixed them in the reference. Would have preferred to fix this locally first but #46113 means I need to test on travis :/

@steveklabnik
Copy link
Member Author

Great, this is passing. Gonna self-r+ so that we can land this before beta, as should have been done over the weekend.

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Nov 20, 2017

📌 Commit a3917b2 has been approved by steveklabnik

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2017
@bors
Copy link
Contributor

bors commented Nov 20, 2017

⌛ Testing commit a3917b2 with merge 33374fa...

bors added a commit that referenced this pull request Nov 20, 2017
Update books for next release

Since I was out last week I didn't get this done as early as usual, I don't know if beta has branched already or not.
@bors
Copy link
Contributor

bors commented Nov 20, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing 33374fa to master...

@bors bors merged commit a3917b2 into rust-lang:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants