Adding RBE as a submodule #46194 #46196

projektir · 2017-11-22T21:31:46Z

Adding RBE as a submodule to start issue #46194.

rust-highfive · 2017-11-22T21:31:57Z

(rust_highfive has picked a reviewer for you, use r? to override)

steveklabnik · 2017-11-22T21:32:58Z

This is a needed step, but the build also needs to be updated to actually build RBE in the correct place. Look in here: https://github.com/rust-lang/rust/blob/master/src/bootstrap/doc.rs

carols10cents · 2017-11-27T14:56:33Z

Triage: this is blocked on rust-lang/rust-by-example#962 to get tidy to pass.

alexcrichton · 2017-11-27T18:06:10Z

r? @steveklabnik

I think I'll leave this one to the docs team

steveklabnik · 2017-11-27T19:28:12Z

I merged the upstream issue.

kennytm · 2017-11-27T19:39:02Z

@projektir You may update the submodule to point at the latest RBE master now.

projektir · 2017-11-27T19:51:50Z

It should already be pointed if I understand submodules right, this just needs to be refreshed?

steveklabnik · 2017-11-27T19:54:45Z

It doesn't look like it. Maybe you forgot to push the new commit?

kennytm · 2017-11-27T21:58:56Z

At least one RBE sample is failing. Our $PATH doesn't contain rustc...

[01:19:09] command did not execute successfully: "/checkout/obj/build/bootstrap/debug/rustdoc" "--test" "/checkout/src/doc/rust-by-example/src/std_misc/process.md" "--test-args" ""
[01:19:09] expected success, got: exit code: 101
[01:19:09] 
[01:19:09] stdout ----
[01:19:09] 
[01:19:09] running 1 test
[01:19:09] test /checkout/src/doc/rust-by-example/src/std_misc/process.md - Child_processes (line 6) ... FAILED
[01:19:09] 
[01:19:09] failures:
[01:19:09] 
[01:19:09] ---- /checkout/src/doc/rust-by-example/src/std_misc/process.md - Child_processes (line 6) stdout ----
[01:19:09] 	thread 'rustc' panicked at 'test executable failed:
[01:19:09] 
[01:19:09] thread 'main' panicked at 'failed to execute process: No such file or directory (os error 2)', /checkout/src/doc/rust-by-example/src/std_misc/process.md:8:12
[01:19:09] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:19:09] 
[01:19:09] ', /checkout/src/librustdoc/test.rs:322:16
[01:19:09] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:19:09] 
[01:19:09] 
[01:19:09] failures:
[01:19:09]     /checkout/src/doc/rust-by-example/src/std_misc/process.md - Child_processes (line 6)
[01:19:09] 
[01:19:09] test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:19:09] 
[01:19:09] 
[01:19:09] stderr ----

steveklabnik · 2017-11-27T22:34:02Z

That's marked as runnable because the playground does...

I would be okay with ignoring it in RBE, I think, as it's not like it's that important anyway.

shepmaster · 2017-12-01T18:52:21Z

@projektir If I am following along correctly, I think you will need to update the submodule reference in this PR again.

projektir · 2018-01-14T00:58:09Z

@steveklabnik We fixed up the various linking issues and looks like this is passing again! 😄

steveklabnik · 2018-01-14T20:16:17Z

@bors: r+

Thank you @projektir ; what should have been a simple PR has really been a wild ride.

bors · 2018-01-14T20:16:18Z

📌 Commit a2df413 has been approved by steveklabnik

bors · 2018-01-14T21:38:20Z

⌛ Testing commit a2df413 with merge dc272c3...

Adding RBE as a submodule #46194 Adding RBE as a submodule to start issue #46194.

bors · 2018-01-15T00:39:05Z

💔 Test failed - status-appveyor

steveklabnik · 2018-01-15T01:12:08Z

The build log is so long I can't see what the failure was. Since it's only on one arch, I'm assuming it was spurious.

@bors: retry

projektir · 2018-01-15T01:27:04Z

Was it this: "Build execution time has reached the maximum allowed time for your plan (180 minutes)."? Seems like the failed arch was Windows GNU. Hopefully spurious...

bors · 2018-01-15T02:02:28Z

⌛ Testing commit a2df413 with merge bb345a0...

Adding RBE as a submodule #46194 Adding RBE as a submodule to start issue #46194.

bors · 2018-01-15T04:50:23Z

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing bb345a0 to master...

@steveklabnik

…teveklabnik Report errors instead of panic!() when linkcheck encounters absolute paths The RBE contained some absolute links that failed the link check in rust-lang#46196. Diagnosing these issues was needlessly complicated, thanks to the linkchecker just panicing instead of reporting proper errors. This PR replaces the panic with a proper `*errors = true` + error message handling. The linkchecker itself doesn't have any tests so I intentionally didn't touch anything else than the code that previously did the `panic!()`. A small code quality improvement might be made by binding the `Path::new(base).join(url)` into a variable before the for-loop and using this resolved url in both the for loop and the error message. r? @steveklabnik (If not for any other reason than having r on the rust-lang#46196.)

@steveklabnik

…teveklabnik Report errors instead of panic!() when linkcheck encounters absolute paths The RBE contained some absolute links that failed the link check in rust-lang#46196. Diagnosing these issues was needlessly complicated, thanks to the linkchecker just panicing instead of reporting proper errors. This PR replaces the panic with a proper `*errors = true` + error message handling. The linkchecker itself doesn't have any tests so I intentionally didn't touch anything else than the code that previously did the `panic!()`. A small code quality improvement might be made by binding the `Path::new(base).join(url)` into a variable before the for-loop and using this resolved url in both the for loop and the error message. r? @steveklabnik (If not for any other reason than having r on the rust-lang#46196.)

@steveklabnik

…teveklabnik Report errors instead of panic!() when linkcheck encounters absolute paths The RBE contained some absolute links that failed the link check in rust-lang#46196. Diagnosing these issues was needlessly complicated, thanks to the linkchecker just panicing instead of reporting proper errors. This PR replaces the panic with a proper `*errors = true` + error message handling. The linkchecker itself doesn't have any tests so I intentionally didn't touch anything else than the code that previously did the `panic!()`. A small code quality improvement might be made by binding the `Path::new(base).join(url)` into a variable before the for-loop and using this resolved url in both the for loop and the error message. r? @steveklabnik (If not for any other reason than having r on the rust-lang#46196.)

@steveklabnik

…teveklabnik Report errors instead of panic!() when linkcheck encounters absolute paths The RBE contained some absolute links that failed the link check in rust-lang#46196. Diagnosing these issues was needlessly complicated, thanks to the linkchecker just panicing instead of reporting proper errors. This PR replaces the panic with a proper `*errors = true` + error message handling. The linkchecker itself doesn't have any tests so I intentionally didn't touch anything else than the code that previously did the `panic!()`. A small code quality improvement might be made by binding the `Path::new(base).join(url)` into a variable before the for-loop and using this resolved url in both the for loop and the error message. r? @steveklabnik (If not for any other reason than having r on the rust-lang#46196.)

…eveklabnik add Rust By Example to the bookshelf cc rust-lang#46194 With rust-lang#46196 freshly merged, we should add a link to the main docs distribution so people can find it! We discussed this at the docs team meeting today and decided to go ahead with adding it to the bookshelf.

rust-highfive assigned alexcrichton Nov 22, 2017

projektir force-pushed the rbe-submodule branch from cd243ce to 8b3f375 Compare November 22, 2017 23:37

projektir mentioned this pull request Nov 23, 2017

Adding license header to deploy.sh rust-lang/rust-by-example#962

Merged

kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 23, 2017

carols10cents added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 27, 2017

rust-highfive assigned steveklabnik and unassigned alexcrichton Nov 27, 2017

projektir force-pushed the rbe-submodule branch from 8b3f375 to 6f0ec5f Compare November 27, 2017 20:08

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 27, 2017

projektir mentioned this pull request Dec 1, 2017

Ignoring process.md as it requires rustc to be present in PATH rust-lang/rust-by-example#968

Merged

shepmaster added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2017

projektir force-pushed the rbe-submodule branch 2 times, most recently from 04ebd7a to e161009 Compare December 2, 2017 02:31

projektir force-pushed the rbe-submodule branch from 554e31c to 152f52e Compare January 12, 2018 04:11

Rantanen mentioned this pull request Jan 12, 2018

Report errors instead of panic!() when linkcheck encounters absolute paths #47387

Merged

Adding RBE as a submodule rust-lang#46194

a2df413

projektir force-pushed the rbe-submodule branch from 152f52e to a2df413 Compare January 13, 2018 21:05

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 14, 2018

steveklabnik approved these changes Jan 14, 2018

View reviewed changes

bors added a commit that referenced this pull request Jan 14, 2018

Auto merge of #46196 - projektir:rbe-submodule, r=steveklabnik

dc272c3

Adding RBE as a submodule #46194 Adding RBE as a submodule to start issue #46194.

steveklabnik added relnotes Marks issues that should be documented in the release notes of the next release. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2018

bors added a commit that referenced this pull request Jan 15, 2018

Auto merge of #46196 - projektir:rbe-submodule, r=steveklabnik

bb345a0

Adding RBE as a submodule #46194 Adding RBE as a submodule to start issue #46194.

bors merged commit a2df413 into rust-lang:master Jan 15, 2018

projektir deleted the rbe-submodule branch January 15, 2018 05:25

QuietMisdreavus mentioned this pull request Jan 17, 2018

add Rust By Example to the bookshelf #47508

Merged

steveklabnik mentioned this pull request Mar 11, 2018

Update RELEASES.md for 1.25.0 #48374

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding RBE as a submodule #46194 #46196

Adding RBE as a submodule #46194 #46196

projektir commented Nov 22, 2017

rust-highfive commented Nov 22, 2017

steveklabnik commented Nov 22, 2017 •

edited

Loading

carols10cents commented Nov 27, 2017

alexcrichton commented Nov 27, 2017

steveklabnik commented Nov 27, 2017

kennytm commented Nov 27, 2017

projektir commented Nov 27, 2017

steveklabnik commented Nov 27, 2017

kennytm commented Nov 27, 2017

steveklabnik commented Nov 27, 2017

shepmaster commented Dec 1, 2017

projektir commented Jan 14, 2018

steveklabnik commented Jan 14, 2018

bors commented Jan 14, 2018

bors commented Jan 14, 2018

bors commented Jan 15, 2018

steveklabnik commented Jan 15, 2018

projektir commented Jan 15, 2018 •

edited

Loading

bors commented Jan 15, 2018

bors commented Jan 15, 2018

Adding RBE as a submodule #46194 #46196

Adding RBE as a submodule #46194 #46196

Conversation

projektir commented Nov 22, 2017

rust-highfive commented Nov 22, 2017

steveklabnik commented Nov 22, 2017 • edited Loading

carols10cents commented Nov 27, 2017

alexcrichton commented Nov 27, 2017

steveklabnik commented Nov 27, 2017

kennytm commented Nov 27, 2017

projektir commented Nov 27, 2017

steveklabnik commented Nov 27, 2017

kennytm commented Nov 27, 2017

steveklabnik commented Nov 27, 2017

shepmaster commented Dec 1, 2017

projektir commented Jan 14, 2018

steveklabnik commented Jan 14, 2018

bors commented Jan 14, 2018

bors commented Jan 14, 2018

bors commented Jan 15, 2018

steveklabnik commented Jan 15, 2018

projektir commented Jan 15, 2018 • edited Loading

bors commented Jan 15, 2018

bors commented Jan 15, 2018

steveklabnik commented Nov 22, 2017 •

edited

Loading

projektir commented Jan 15, 2018 •

edited

Loading