avoid type-live-for-region obligations on dummy nodes #46226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
added
the
beta-nominated
kennytm
added
the
S-waiting-on-review
kennytm
reviewed
Nov 24, 2017
src/librustc/traits/mod.rs
Outdated
| // them here too, and we will remove this function when | ||
| // we move over to lazy normalization *anyway*. | ||
| let fulfill_cx = FulfillmentContext::new_ignoring_regions(); | ||
|
|
||
| let predicates = match fully_normalize( |
There was a problem hiding this comment.
You mean fully_normalize_with_fulfillcx here?
[00:08:49] error[E0061]: this function takes 4 parameters but 5 parameters were supplied
[00:08:49] --> /checkout/src/librustc/traits/mod.rs:533:13
[00:08:49] |
[00:08:49] 533 | &infcx,
[00:08:49] | ^^^^^^ expected 4 parameters
[00:08:49] ...
[00:08:49] 588 | / pub fn fully_normalize<'a, 'gcx, 'tcx, T>(infcx: &InferCtxt<'a, 'gcx, 'tcx>,
[00:08:49] 589 | | cause: ObligationCause<'tcx>,
[00:08:49] 590 | | param_env: ty::ParamEnv<'tcx>,
[00:08:49] 591 | | value: &T)
[00:08:49] ... |
[00:08:49] 609 | | fully_normalize_with_fulfillcx(infcx, fulfillcx, cause, param_env, value)
[00:08:49] 610 | | }
[00:08:49] | |_- defined here
Type-live-for-region obligations on DUMMY_NODE_ID cause an ICE, and it turns out that in the few cases they are needed, these obligations are not needed anyway because they are verified elsewhere. Fixes rust-lang#46069.
arielb1
force-pushed
the
special-region-obligation
branch
from
facb820 to
ebd219a
Compare
nikomatsakis
approved these changes
Nov 28, 2017
|
@bors r+ |
|
📌 Commit ebd219a has been approved by |
nikomatsakis
added
beta-accepted
kennytm
added
S-waiting-on-bors
|
⌛ Testing commit ebd219a with merge 2212da6e98381f57e4f0b8306ba595f9fc999c8b... |
|
💔 Test failed - status-travis |
|
@bors retry — travis-ci/travis-ci#8821 |
bors
added a commit
that referenced
this pull request
Nov 30, 2017
avoid type-live-for-region obligations on dummy nodes Type-live-for-region obligations on DUMMY_NODE_ID cause an ICE, and it turns out that in the few cases they are needed, these obligations are not needed anyway because they are verified elsewhere. Fixes #46069. Beta-nominating because this is a regression for our new beta. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
|
Hmm, was it supposed to be backported to 1.23.0? Stable 1.23.0 fails the test in this pull request. |
|
Looks like we forgot to backport to 1.23.0 (sorry about that!) so removing the beta tags. |
alexcrichton
removed
beta-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type-live-for-region obligations on DUMMY_NODE_ID cause an ICE, and it
turns out that in the few cases they are needed, these obligations are not
needed anyway because they are verified elsewhere.
Fixes #46069.
Beta-nominating because this is a regression for our new beta.
r? @nikomatsakis