Skip to content

Conversation

canndrew
Copy link
Contributor

We no longer need a separately-named never_type_impls gate thanks to #43089.

@rust-highfive
Copy link
Contributor

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@canndrew
Copy link
Contributor Author

Note: This PR builds on #46232

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 25, 2017
@shepmaster
Copy link
Member

r? @petrochenkov

@petrochenkov
Copy link
Contributor

Stability attributes on impls are documentation-only, so this doesn't seem harmful in any way.
r=me after #46232 is approved

@kennytm kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2017
@kennytm kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Dec 6, 2017
@kennytm
Copy link
Member

kennytm commented Dec 11, 2017

#46232 has been merged.

@petrochenkov
Copy link
Contributor

Needs rebase
@bors delegate+

@bors
Copy link
Collaborator

bors commented Dec 11, 2017

✌️ @canndrew can now approve this pull request

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2017
@canndrew canndrew force-pushed the rename-never-type-impl-gate branch from 00047ae to b9df045 Compare December 12, 2017 06:03
@kennytm
Copy link
Member

kennytm commented Dec 12, 2017

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Dec 12, 2017

📌 Commit b9df045 has been approved by petrochenkov

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 12, 2017
@bors
Copy link
Collaborator

bors commented Dec 12, 2017

⌛ Testing commit b9df045 with merge 4c2819d...

bors added a commit that referenced this pull request Dec 12, 2017
…henkov

Rename never_type_impls gate

We no longer need a separately-named `never_type_impls` gate thanks to #43089.
@bors
Copy link
Collaborator

bors commented Dec 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 4c2819d to master...

@bors bors merged commit b9df045 into rust-lang:master Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants