Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename never_type_impls gate #46250

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Rename never_type_impls gate #46250

merged 1 commit into from
Dec 12, 2017

Conversation

canndrew
Copy link
Contributor

We no longer need a separately-named never_type_impls gate thanks to #43089.

@rust-highfive
Copy link
Collaborator

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@canndrew canndrew mentioned this pull request Nov 25, 2017
Merged
@canndrew
Copy link
Contributor Author

Note: This PR builds on #46232

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 25, 2017
@shepmaster
Copy link
Member

r? @petrochenkov

@petrochenkov
Copy link
Contributor

Stability attributes on impls are documentation-only, so this doesn't seem harmful in any way.
r=me after #46232 is approved

@kennytm kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2017
@kennytm kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Dec 6, 2017
@kennytm
Copy link
Member

kennytm commented Dec 11, 2017

#46232 has been merged.

@petrochenkov
Copy link
Contributor

Needs rebase
@bors delegate+

@bors
Copy link
Contributor

bors commented Dec 11, 2017

✌️ @canndrew can now approve this pull request

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2017
@canndrew canndrew force-pushed the rename-never-type-impl-gate branch from 00047ae to b9df045 Compare December 12, 2017 06:03
@kennytm
Copy link
Member

kennytm commented Dec 12, 2017

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Dec 12, 2017

📌 Commit b9df045 has been approved by petrochenkov

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 12, 2017
@bors
Copy link
Contributor

bors commented Dec 12, 2017

⌛ Testing commit b9df045 with merge 4c2819d...

bors added a commit that referenced this pull request Dec 12, 2017
@bors
Auto merge of #46250 - canndrew:rename-never-type-impl-gate, r=petroc…
4c2819d 
…henkov

Rename never_type_impls gate

We no longer need a separately-named `never_type_impls` gate thanks to #43089.
@bors
Copy link
Contributor

bors commented Dec 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 4c2819d to master...

@bors bors merged commit b9df045 into rust-lang:master Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@canndrew @rust-highfive @shepmaster @petrochenkov @kennytm @bors