Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow feature-gate tests to live in ui/ and migrate most of the tests from compile-fail #46532

Merged
merged 3 commits into from
Dec 7, 2017
Merged

Allow feature-gate tests to live in ui/ and migrate most of the tests from compile-fail #46532

merged 3 commits into from
Dec 7, 2017

Commits on Dec 7, 2017

  1. Tidy: allow feature-gate tests to be ui tests 

    ui tests are the future, especially since the
recent improvement where we have gained
checking and requiring of //~ERROR comments.

The tidy feature-gate test check is intended
to be 50% an actual insurance that there is
a check, and 50% to be a teacher that such
checks are required.

With this commit applied, newbies might
interpret stuff wrongly and create tests
that don't fail but succeed instead.

This is not what feature gate tests are
for though. Therefore, in a later step,
when only ui tests are allowed to be feature
gate tests, we will add checking to ensure
that a file marked as gate test is actually
required to be a compilation failure.

Right now implementing such a check is a
bit annoying as one needs to only do it
when the compile-fail test is in the
ui test suite :/.
    @est31
    est31 committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    8ba9f9e View commit details
    Browse the repository at this point in the history

  2. Migrate a few feature gate tests to ui 

    Renames only in this commit, and obviously
.stderr file additions.
    @est31
    est31 committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    38438c6 View commit details
    Browse the repository at this point in the history

  3. Migrate even more feature gate tests to ui 

    We also rename some of the files to conform to the
feature-gate-<feat_name>.rs pattern that is most common.
    @est31
    est31 committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    6dba3e6 View commit details
    Browse the repository at this point in the history