Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a better link for method resolution in Deref docs #46601

Merged
merged 1 commit into from
Dec 15, 2017
Merged

Use a better link for method resolution in Deref docs #46601

merged 1 commit into from
Dec 15, 2017

Conversation

matthewjasper
Copy link
Contributor

rust-lang/reference#149 breaks these links, so make them point to somewhere which won't break and provides a more deatailed description of method resolution.

cc @Havvy
r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 9, 2017
@Havvy
Copy link
Contributor

Havvy commented Dec 10, 2017

A cursory glance, but LGTM.

@aidanhs
Copy link
Member

aidanhs commented Dec 14, 2017 •
edited
Loading

ping @steveklabnik for review! (also on IRC)

@steveklabnik
Copy link
Member

@bors: r+ rollup

agreed, thank you!

@bors
Copy link
Contributor

bors commented Dec 14, 2017

📌 Commit d755be6 has been approved by steveklabnik

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2017
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Dec 15, 2017
@steveklabnik
Rollup merge of rust-lang#46601 - matthewjasper:method-link-change, r…
ba67acc 
…=steveklabnik

Use a better link for method resolution in Deref docs

rust-lang/reference#149 breaks these links, so make them point to somewhere which won't break and provides a more deatailed description of method resolution.

cc @Havvy
r? @steveklabnik
@steveklabnik steveklabnik mentioned this pull request Dec 15, 2017
Merged
bors added a commit that referenced this pull request Dec 15, 2017
@bors
Auto merge of #46745 - steveklabnik:rollup, r=steveklabnik
50f6c3e 
Rollup of 7 pull requests

- Successful merges: #46601, #46652, #46690, #46705, #46710, #46728, #46737
- Failed merges:
@bors bors merged commit d755be6 into rust-lang:master Dec 15, 2017
@bors
Copy link
Contributor

bors commented Dec 15, 2017

☔ The latest upstream changes (presumably #46745) made this pull request unmergeable. Please resolve the merge conflicts.

@matthewjasper matthewjasper deleted the method-link-change branch December 15, 2017 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik approved these changes

Assignees

@steveklabnik steveklabnik

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@matthewjasper @rust-highfive @Havvy @aidanhs @steveklabnik @bors @kennytm @shepmaster