Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace libtest/lib.rs:FnBox with std::boxed::FnBox. #46636

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Replace libtest/lib.rs:FnBox with std::boxed::FnBox. #46636

merged 1 commit into from
Dec 22, 2017

Conversation

frewsxcv
Copy link
Member

Fixes #41810.

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 10, 2017
@frewsxcv frewsxcv force-pushed the frewsxcv-fn-box branch 4 times, most recently from 7e601ee to cbd2710 Compare December 11, 2017 02:56
kennytm
kennytm reviewed Dec 14, 2017
View reviewed changes
src/libtest/lib.rs Outdated
@@ -1720,7 +1710,7 @@ mod tests {
should_panic: ShouldPanic::No,
allow_fail: false,
},
testfn: DynTestFn(Box::new(move |()| f())),
testfn: DynTestFn(Box::new(move || f())),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can simply be Box::new(f) I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in the latest force push

@frewsxcv frewsxcv added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 17, 2017
@frewsxcv
Copy link
Member Author

assigning to someone random from the compiler team (unless there's a better team to review this)

r? @estebank

@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 21, 2017

📌 Commit 4f04f97 has been approved by estebank

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Dec 21, 2017
@kennytm
Rollup merge of rust-lang#46636 - frewsxcv:frewsxcv-fn-box, r=estebank
71c6d23 
Replace libtest/lib.rs:FnBox with std::boxed::FnBox.

Fixes rust-lang#41810.
@kennytm kennytm mentioned this pull request Dec 21, 2017
Merged
bors added a commit that referenced this pull request Dec 21, 2017
@bors
Auto merge of #46922 - kennytm:rollup, r=kennytm
ba27415 
Rollup of 14 pull requests

- Successful merges: #46636, #46780, #46784, #46809, #46814, #46820, #46839, #46847, #46858, #46878, #46884, #46890, #46898, #46918
- Failed merges:
@bors bors merged commit 4f04f97 into rust-lang:master Dec 22, 2017
@dwrensha dwrensha mentioned this pull request Dec 23, 2017
Merged
@pitdicker pitdicker mentioned this pull request Jan 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frewsxcv @estebank @bors @kennytm