core: convert ToStr::to_str to take explicit &self #4684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Running a try build just to make sure I didn't mess anything up while merging, then will push. |
|
Huh, after rebasing against incoming, the result is an LLVM assertion failure when building coretest. I'll investigate further (certainly not your fault!) |
|
Sorry! Out of control bot |
|
This has been rebased onto HEAD, and the test that was triggering that LLVM assertion failure @catamorphism mentioned has been worked around. I think that was coming from #4760, but I haven't confirmed it yet. I've pushed this to |
brson
added a commit
that referenced
this pull request
Feb 4, 2013
core: convert ToStr::to_str to take explicit &self
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.