Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incr.comp.: Use an array instead of a hashmap for storing result hashes. #46842

Merged
merged 2 commits into from
Dec 23, 2017
Merged

incr.comp.: Use an array instead of a hashmap for storing result hashes. #46842

merged 2 commits into from
Dec 23, 2017

Conversation

michaelwoerister
Copy link
Member

Doing so should result in some of the core tracking components being faster.

r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

Travis ICE looks legitimate.

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 19, 2017
@michaelwoerister
Copy link
Member Author

Seems like I was compiling with debug assertions off locally. Should be fixed now.

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 20, 2017
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Dec 20, 2017

📌 Commit b2f7239 has been approved by nikomatsakis

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2017
@bors
Copy link
Contributor

bors commented Dec 22, 2017

⌛ Testing commit b2f7239 with merge 705ef67686b821588d9c0094e406add58362671e...

@bors
Copy link
Contributor

bors commented Dec 22, 2017

💔 Test failed - status-appveyor

@michaelwoerister
Copy link
Member Author

@bors retry

@bors
Copy link
Contributor

bors commented Dec 22, 2017

⌛ Testing commit b2f7239 with merge f0cf23e...

bors added a commit that referenced this pull request Dec 22, 2017
@bors
Auto merge of #46842 - michaelwoerister:fingerprint-vec, r=nikomatsakis
f0cf23e 
incr.comp.: Use an array instead of a hashmap for storing result hashes.

Doing so should result in some of the core tracking components being faster.

r? @nikomatsakis
@bors
Copy link
Contributor

bors commented Dec 23, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing f0cf23e to master...

@bors bors merged commit b2f7239 into rust-lang:master Dec 23, 2017
This was referenced Dec 23, 2017
Merged
Merged
Closed
Closed
@michaelwoerister michaelwoerister mentioned this pull request Jan 22, 2018
Open
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelwoerister @nikomatsakis @bors @kennytm