Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify docs for split_at_mut #46930

Merged
merged 1 commit into from
Dec 26, 2017
Merged

Clarify docs for split_at_mut #46930

merged 1 commit into from
Dec 26, 2017

Conversation

0xSiO
Copy link
Contributor

@0xSiO 0xSiO commented Dec 21, 2017

The &mut here didn't make immediate sense to me. Keep the docs for this function consistent with the non-mut version.

@lucis-fluxum
Clarify docs for split_at_mut
8a956e4 
The `&mut` here didn't make immediate sense to me. Keep the docs for this function consistent with the non-mut version.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Kimundi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@QuietMisdreavus
Copy link
Member

Ooh, i like this one better, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 21, 2017

📌 Commit 8a956e4 has been approved by QuietMisdreavus

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 22, 2017
@kennytm kennytm mentioned this pull request Dec 23, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Dec 23, 2017
@kennytm
Rollup merge of rust-lang#46930 - lucis-fluxum:patch-1, r=QuietMisdre…
089e617 
…avus

Clarify docs for split_at_mut

The `&mut` here didn't make immediate sense to me. Keep the docs for this function consistent with the non-mut version.
@kennytm kennytm mentioned this pull request Dec 23, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Dec 23, 2017
@kennytm
Rollup merge of rust-lang#46930 - lucis-fluxum:patch-1, r=QuietMisdre…
f6e1c4f 
…avus

Clarify docs for split_at_mut

The `&mut` here didn't make immediate sense to me. Keep the docs for this function consistent with the non-mut version.
@bors
Copy link
Contributor

bors commented Dec 25, 2017

⌛ Testing commit 8a956e4 with merge 1fb8e77d2b262776fc6a822328ac4808ad9a1b4c...

@bors
Copy link
Contributor

bors commented Dec 25, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Dec 25, 2017 •
edited
Loading

@bors retry #47002

@bors
Copy link
Contributor

bors commented Dec 26, 2017

⌛ Testing commit 8a956e4 with merge 4b5df5aacbb1ae70293dc77009de37f39a154cbd...

@bors
Copy link
Contributor

bors commented Dec 26, 2017

💔 Test failed - status-travis

kennytm added a commit to kennytm/rust that referenced this pull request Dec 26, 2017
@kennytm
Rollup merge of rust-lang#46930 - lucis-fluxum:patch-1, r=QuietMisdre…
ba39972 
…avus

Clarify docs for split_at_mut

The `&mut` here didn't make immediate sense to me. Keep the docs for this function consistent with the non-mut version.
@kennytm kennytm mentioned this pull request Dec 26, 2017
Merged
bors added a commit that referenced this pull request Dec 26, 2017
@bors
Auto merge of #47012 - kennytm:rollup, r=kennytm
8cdde6d 
Rollup of 8 pull requests

- Successful merges: #46928, #46930, #46933, #46939, #46940, #46943, #46979, #46986
- Failed merges:
@bors bors merged commit 8a956e4 into rust-lang:master Dec 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik approved these changes

Assignees

@Kimundi Kimundi

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@0xSiO @rust-highfive @QuietMisdreavus @bors @kennytm @steveklabnik @Kimundi @lucis-fluxum