Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clippy #47172

Closed
wants to merge 1 commit into from
Closed

Update clippy #47172

wants to merge 1 commit into from

Conversation

Manishearth
Copy link
Member

@alexcrichton
Copy link
Member

Looks like CI may be failing b/c the lock file needs to be updated? Other than that r=me

@Manishearth
Copy link
Member Author

@bors r=alexcrichton p=3

(p+ for it to reach beta)

@bors
Copy link
Contributor

bors commented Jan 4, 2018

📌 Commit ff1ecd4 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jan 4, 2018

⌛ Testing commit ff1ecd4f612ee3789a4a7d72453d931573a5c96a with merge 8d138f932730e80517000cfcc8c220fd2e70b1c8...

@kennytm
Copy link
Member

kennytm commented Jan 4, 2018

@Manishearth 1.24 beta has already been branched off, this PR won’t reach it unless we backport.

@Manishearth
Copy link
Member Author

Ah. Is is important for this PR to reach it? Or is it ok because we don't ship clippy with rustup yet?

@kennytm
Copy link
Member

kennytm commented Jan 4, 2018

According to #47119 (comment) it is OK not to backport it because we don't ship clippy yet.

@bors
Copy link
Contributor

bors commented Jan 4, 2018

💔 Test failed - status-travis

@Manishearth
Copy link
Member Author

@bors r=alexcrichton

needed a compiletest bump

@bors
Copy link
Contributor

bors commented Jan 4, 2018

📌 Commit aaf099e has been approved by alexcrichton

@kennytm kennytm mentioned this pull request Jan 4, 2018
@bors
Copy link
Contributor

bors commented Jan 4, 2018

⌛ Testing commit aaf099e with merge c358867...

bors added a commit that referenced this pull request Jan 4, 2018
@bors
Copy link
Contributor

bors commented Jan 4, 2018

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Jan 4, 2018

Legit, test failed due to read-only filesystem. Looks like still the same error we've seen before at #46554 (comment)

[01:06:06] ---- compile_test stdout ----
[01:06:06] 	thread 'compile_test' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 30, message: "Read-only file system" } }', /checkout/src/libcore/result.rs:916:5
[01:06:06] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:06:06] 
[01:06:06] 
[01:06:06] failures:
[01:06:06]     compile_test

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 4, 2018
@shepmaster
Copy link
Member

Ping from triage, @Manishearth! Will you have time to address the reported issues in the near future?

@Manishearth
Copy link
Member Author

Not really, and I don't know what's going on. Perhaps @oli-obk does?

@aidanhs aidanhs added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 17, 2018
@bors
Copy link
Contributor

bors commented Jan 18, 2018

☔ The latest upstream changes (presumably #47280) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk mentioned this pull request Jan 18, 2018
@carols10cents
Copy link
Member

Looks like this is replaced by #47557, so I'm closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants