Skip to content

Add help message for incorrect pattern syntax #47232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 8, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/libsyntax/parse/parser.rs
Original file line number Diff line number Diff line change
@@ -3431,8 +3431,20 @@ impl<'a> Parser<'a> {
let mut pats = Vec::new();
loop {
pats.push(self.parse_pat()?);
if self.check(&token::BinOp(token::Or)) { self.bump();}
else { return Ok(pats); }

if self.token == token::OrOr {
let mut err = self.struct_span_err(self.span,
"unexpected token `||` after pattern");
err.span_suggestion(self.span,
"use a single `|` to specify multiple patterns",
"|".to_owned());
err.emit();
self.bump();
} else if self.check(&token::BinOp(token::Or)) {
self.bump();
} else {
return Ok(pats);
}
};
}

17 changes: 17 additions & 0 deletions src/test/ui/did_you_mean/multiple-pattern-typo.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

fn main() {
let x = 3;
match x {
1 | 2 || 3 => (), //~ ERROR unexpected token `||` after pattern
_ => (),
}
}
8 changes: 8 additions & 0 deletions src/test/ui/did_you_mean/multiple-pattern-typo.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
error: unexpected token `||` after pattern
--> $DIR/multiple-pattern-typo.rs:14:15
|
14 | 1 | 2 || 3 => (), //~ ERROR unexpected token `||` after pattern
| ^^ help: use a single `|` to specify multiple patterns: `|`

error: aborting due to previous error