Skip to content

Account for pub in const -> static suggestion #47262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2018
Merged

Account for pub in const -> static suggestion #47262

merged 1 commit into from
Jan 10, 2018

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Jan 8, 2018

Fix #45562.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank estebank added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2018
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 9, 2018

📌 Commit 0528693 has been approved by petrochenkov

@petrochenkov petrochenkov added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2018
@frewsxcv
Copy link
Contributor

@bors rollup

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jan 10, 2018
@frewsxcv
Rollup merge of rust-lang#47262 - estebank:issue-45562, r=petrochenkov
14284f3 
Account for `pub` in `const` -> `static` suggestion

Fix rust-lang#45562.
@frewsxcv frewsxcv mentioned this pull request Jan 10, 2018
Merged
bors added a commit that referenced this pull request Jan 10, 2018
@bors
Auto merge of #47308 - frewsxcv:rollup, r=frewsxcv
92c32d2 
Rollup of 5 pull requests

- Successful merges: #46762, #46777, #47262, #47285, #47301
- Failed merges:
@bors bors merged commit 0528693 into rust-lang:master Jan 10, 2018
@estebank estebank deleted the issue-45562 branch November 9, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@estebank @rust-highfive @petrochenkov @bors @frewsxcv