Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten names of some compiler generated artifacts. #47269

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

michaelwoerister
Copy link
Member

This PR makes the compiler mangle codegen unit names by default. The name of every codegen unit name will now be a random string of 16 characters. It also makes the file extensions of some intermediate compiler products shorter. Hopefully, these changes will reduce the pressure on tools with path length restrictions like buildbot. The change should also solve problems with case-insensitive file system.

cc #47186 and #47222

r? @alexcrichton

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2018
@alexcrichton
Copy link
Member

@bors: r+

Looks great!

FWIW one thing I've found that works out well in Cargo is to do something like $known_prefix-$hash so it's a little debuggable still w/o extra flags, but we can always implement that in an on-demand basis.

@bors
Copy link
Contributor

bors commented Jan 8, 2018

📌 Commit 94f3037 has been approved by alexcrichton

@alexcrichton alexcrichton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 8, 2018
@alexcrichton
Copy link
Member

Also nominating for a beta backport as incremental is turned on by default in beta.

@michaelwoerister michaelwoerister added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2018
@michaelwoerister
Copy link
Member Author

@bors p=1

@bors
Copy link
Contributor

bors commented Jan 9, 2018

⌛ Testing commit 94f3037 with merge 61452e5...

bors added a commit that referenced this pull request Jan 9, 2018
…hton

Shorten names of some compiler generated artifacts.

This PR makes the compiler mangle codegen unit names by default. The name of every codegen unit name will now be a random string of 16 characters. It also makes the file extensions of some intermediate compiler products shorter. Hopefully, these changes will reduce the pressure on tools with path length restrictions like buildbot. The change should also solve problems with case-insensitive file system.

cc #47186 and #47222

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Jan 9, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 61452e5 to master...

@alexcrichton
Copy link
Member

Accepting for beta as this fixes #47222

@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 10, 2018
@MaloJaffre MaloJaffre mentioned this pull request Jan 10, 2018
bors added a commit that referenced this pull request Jan 10, 2018
[beta] Backports

Cherry-picked (cleanly) into beta:
- #46916
- #47161
- #47208
- #47269
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants