Remove impl Foo for .. {} in favor auto trait Foo {}
#47416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer parse it. Remove AutoTrait variant from AST and HIR. Remove backwards compatibility lint. Remove coherence checks, they make no sense for the new syntax. Remove from rustdoc.
The WF checks are now done as an AST validation.
`fn check_impl` was feeling lonely with a file all for itself.
Also refactored parsing auto traits.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 2259877 has been approved by |
|
⌛ Testing commit 2259877 with merge 83933abf871db52564d7d60790f6e9d0188c0de6... |
eddyb
reviewed
Jan 13, 2018
| ty = self.parse_ty()?; | ||
| if opt_trait.is_some() { | ||
| ty = if self.eat(&token::DotDot) { | ||
| P(Ty { node: TyKind::Err, span: self.prev_span, id: ast::DUMMY_NODE_ID }) |
There was a problem hiding this comment.
Wait, does this actually trigger any errors, at all?
EDIT: nevermind, it's in src/librustc_passes/ast_validation.rs.
|
💔 Test failed - status-appveyor |
bors
added a commit
that referenced
this pull request
Jan 13, 2018
…henkov
Remove `impl Foo for .. {}` in favor `auto trait Foo {}`
Rebase of #46480 with restored parsing support.
|
☀️ Test successful - status-appveyor, status-travis |
kennytm-githubbot
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jan 14, 2018
Tested on commit rust-lang/rust@cf4c3cb. 💔 rls on windows: test-pass → build-fail (cc @nrc). 💔 rls on linux: test-pass → build-fail (cc @nrc). 💔 rustfmt on windows: test-pass → build-fail (cc @nrc). 💔 rustfmt on linux: test-pass → build-fail (cc @nrc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #46480 with restored parsing support.