Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement "only-<platforms>" for test headers #47484

Closed
wants to merge 4 commits into from
Closed

implement "only-<platforms>" for test headers #47484

wants to merge 4 commits into from

Conversation

Pulkit07
Copy link
Contributor

This patch implements "only-" for tests headers using which one can
specify just the platforms on which the test should run rather than listing all
the platforms to ignore using "ignore-".

This is a fix for issues #33581 and #47459.

Adam C. Foltzer and others added 4 commits January 15, 2018 13:18
remove dep-info files as targets in themselves
7e99764
Add -Z dep-info-omit-d-target to control dep-info style
8c09d29 
This avoids a breaking change to dep-info output, putting the
gcc/clang-compliant dep-info behavior behind a flag
@bors
Auto merge of #47035 - acfoltzer:dep-info-tweak, r=alexcrichton
a1fd7bd 
Remove dep-info files as targets in themselves

If you ask `rustc` to `--emit dep-info`, the resulting dependency file contains a rule for producing the dependency file itself. This differs from the output of `gcc -MD` or `clang -MD`, which only includes dependency rules for the object files produced.

Tools like Ninja often consume and delete dependency files as soon as they’re produced for performance reasons, particularly on Windows. In the case of `rustc` output, though, the recently-deleted dependency file is cached by Ninja as a target, and therefore triggers a rebuild every time.

This very small patch removes the dep-info file from the list of output filenames, so it matches the behavior of gcc and clang.
@Pulkit07
implement "only-<platforms>" for test headers
98c1d9e 
This patch implements "only-<platforms>" for tests headers using which one can
specify just the platforms on which the test should run rather than listing all
the platforms to ignore using "ignore-<platform>".

This is a fix for issues #33581 and #47459.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against auto. Please double check that you specified the right target!

@Pulkit07
Copy link
Contributor Author

Looks like I messed up with branches here, I will make a new pull request.

@Pulkit07 Pulkit07 closed this Jan 16, 2018
@varkor
Copy link
Member

varkor commented Jan 16, 2018

You can modify the base branch of an open pull request, just as a tip for the future!

@Pulkit07
Copy link
Contributor Author

@vakor thanks for the tip. On command line, I rebased it on the auto and then was unable to rebase back to master and messed up. Hence, decided to create a new one. But again thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Pulkit07 @rust-highfive @varkor @nikomatsakis @bors