implement "only-<platforms>" for test headers #47484
Conversation
This avoids a breaking change to dep-info output, putting the gcc/clang-compliant dep-info behavior behind a flag
Remove dep-info files as targets in themselves If you ask `rustc` to `--emit dep-info`, the resulting dependency file contains a rule for producing the dependency file itself. This differs from the output of `gcc -MD` or `clang -MD`, which only includes dependency rules for the object files produced. Tools like Ninja often consume and delete dependency files as soon as they’re produced for performance reasons, particularly on Windows. In the case of `rustc` output, though, the recently-deleted dependency file is cached by Ninja as a target, and therefore triggers a rebuild every time. This very small patch removes the dep-info file from the list of output filenames, so it matches the behavior of gcc and clang.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
|
|
Looks like I messed up with branches here, I will make a new pull request. |
|
You can modify the base branch of an open pull request, just as a tip for the future! |
|
@vakor thanks for the tip. On command line, I rebased it on the auto and then was unable to rebase back to master and messed up. Hence, decided to create a new one. But again thanks. |
5 participants
This patch implements "only-" for tests headers using which one can
specify just the platforms on which the test should run rather than listing all
the platforms to ignore using "ignore-".
This is a fix for issues #33581 and #47459.