Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #47528

Merged
merged 18 commits into from
Jan 18, 2018
Merged

Rollup of 6 pull requests #47528

merged 18 commits into from
Jan 18, 2018

Conversation

ollie27 and others added 18 commits January 10, 2018 07:05
This means default methods can always be found and "Important traits" will include all spotlight traits.
On required type annotation diagnostic error, point at method with the
requirements if the span is available.
This replaces a `stat` syscall with `fstat` or similar, which can be
faster.  Fixes rust-lang#47519.
…ark-Simulacrum

Test rustdoc js

Add tests for the rustdoc search. It was heavily required because of all the recent breaking changes that happened while I went through improvements in doc search (add search in/for generic search for example).
…, r=QuietMisdreavus

rustdoc: Populate external_traits with traits only seen in impls

This means default methods can always be found and "Important traits" will include all spotlight traits.
…=QuietMisdreavus

Switch to pulldown as default markdown renderer

r? @QuietMisdreavus
Do not suggest to make `mut` binding external to `Fn` closure

Re rust-lang#46834.
…nkfelix

On E0283, point at method with the requirements

On required type annotation diagnostic error, point at method with the
requirements if the span is available.

CC rust-lang#45453.
Use File::metadata instead of fs::metadata to choose buffer size

This replaces a `stat` syscall with `fstat` or similar, which can be faster.  Fixes rust-lang#47519.
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez
Copy link
Member Author

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Jan 17, 2018

📌 Commit 2606537 has been approved by GuillaumeGomez

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 17, 2018
@kennytm
Copy link
Member

kennytm commented Jan 18, 2018

@bors p=6

@bors
Copy link
Contributor

bors commented Jan 18, 2018

⌛ Testing commit 2606537 with merge bbb3ff678113a74b4836e779b8c0c6bc736d9f76...

@bors
Copy link
Contributor

bors commented Jan 18, 2018

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Jan 18, 2018

@bors retry

[00:18:51]    Compiling rustc_data_structures v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc_data_structures)
[00:19:11]    Compiling syntax_pos v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/libsyntax_pos)
[00:19:25]    Compiling rustc_errors v0.0.0 (file:///Users/travis/build/rust-lang/rust/src/librustc_errors)
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

@bors
Copy link
Contributor

bors commented Jan 18, 2018

⌛ Testing commit 2606537 with merge a58b55c1207fd478f2179fab9ab9976bf777474e...

@bors
Copy link
Contributor

bors commented Jan 18, 2018

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Jan 18, 2018

30 minutes timeout again 🤔 Let me do some investigation first.

@kennytm
Copy link
Member

kennytm commented Jan 18, 2018

@bors retry #47539

@bors
Copy link
Contributor

bors commented Jan 18, 2018

⌛ Testing commit 2606537 with merge 3bd4af8...

bors added a commit that referenced this pull request Jan 18, 2018
Rollup of 6 pull requests

- Successful merges: #47250, #47313, #47398, #47468, #47471, #47520
- Failed merges:
@bors
Copy link
Contributor

bors commented Jan 18, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: GuillaumeGomez
Pushing 3bd4af8 to master...

@bors bors merged commit 2606537 into rust-lang:master Jan 18, 2018
@GuillaumeGomez GuillaumeGomez deleted the rollup branch January 18, 2018 18:01
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants