Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type inhabitedness check for arrays #47600

Merged
merged 2 commits into from
Jan 26, 2018
Merged

Fix type inhabitedness check for arrays #47600

merged 2 commits into from
Jan 26, 2018

Conversation

varkor
Copy link
Member

@varkor varkor commented Jan 19, 2018

Arrays of uninhabited types were considered to also be uninhabited if
their length had not been evaluated, causing unsoundness.

Fixes #47563.

r? @eddyb

@varkor
Fix type inhabitedness check for arrays
768cbbc 
Arrays of uninhabited types were considered to also be uninhabited if
their length had not been evaluated, causing unsoundness.
@eddyb
Copy link
Member

eddyb commented Jan 19, 2018

@bors r+ Thanks!

@bors
Copy link
Contributor

bors commented Jan 19, 2018

📌 Commit 768cbbc has been approved by eddyb

@varkor
Copy link
Member Author

varkor commented Jan 19, 2018

For some reason, despite testing tidy beforehand, I forgot to actually fix it. I guess it'll need r+'ing again now.

@eddyb
Copy link
Member

eddyb commented Jan 20, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Jan 20, 2018

📌 Commit c4d0bb3 has been approved by eddyb

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 20, 2018
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 25, 2018
@alexcrichton
Rollup merge of rust-lang#47600 - varkor:empty-never-array, r=eddyb
9852b23 
Fix type inhabitedness check for arrays

Arrays of uninhabited types were considered to also be uninhabited if
their length had not been evaluated, causing unsoundness.

Fixes rust-lang#47563.

r? @eddyb
@alexcrichton alexcrichton mentioned this pull request Jan 25, 2018
Merged
bors added a commit that referenced this pull request Jan 26, 2018
@bors
Auto merge of #47748 - alexcrichton:rollup, r=alexcrichton
bacb5c5 
Rollup of 19 pull requests

- Successful merges: #47415, #47437, #47439, #47453, #47460, #47502, #47529, #47600, #47607, #47618, #47626, #47656, #47668, #47696, #47701, #47705, #47710, #47711, #47719
- Failed merges: #47455, #47521
@bors bors merged commit c4d0bb3 into rust-lang:master Jan 26, 2018
@varkor varkor deleted the empty-never-array branch January 27, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@varkor @eddyb @bors @shepmaster