Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not assume dynamic linking for musl/mips[el] targets #47663

Merged
merged 6 commits into from
Jan 29, 2018
Merged

Do not assume dynamic linking for musl/mips[el] targets #47663

merged 6 commits into from
Jan 29, 2018

Commits on Jan 22, 2018

  1. Do not assume dynamic linking for musl/mips[el] targets 

    All musl targets except mips[el] assume static linking by default. This
can be confusing
https://users.rust-lang.org/t/static-cross-compiled-binaries-arent-really-static/6084

When the musl/mips[el] targets was
[added](rust-lang#31298), dynamic linking
was chosen because of binary size concerns, and probably also because
libunwind
[didn't](https://users.rust-lang.org/t/static-cross-compiled-binaries-arent-really-static/6084/8)
supported mips.

Now that we have `crt-static` target-feature (the user can choose
dynamic link for musl targets), and libunwind
[6.0](https://github.com/llvm-mirror/libunwind/commits/release_60) add
support to mips, we do not need to assume dynamic linking.
    @malbarbo
    malbarbo committed Jan 22, 2018
    Configuration menu
    Copy the full SHA
    68db72d View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2018

  1. Set crt_static_default = false for musl/mips[el] targets

    @malbarbo
    malbarbo committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    61fdf8e View commit details
    Browse the repository at this point in the history

  2. Use libuwind 6.0 for all musl targets

    @malbarbo
    malbarbo committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    abc1061 View commit details
    Browse the repository at this point in the history

  3. Build musl with -fPIC for all targets

    @malbarbo
    malbarbo committed Jan 23, 2018
    Configuration menu
    Copy the full SHA
    9b13e40 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2018

  1. Update libc

    @malbarbo
    malbarbo committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    cd47ddf View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2018

  1. Remove musl/libunwind patch for i686 

    The i686 problem was fixed upstream:
llvm-mirror/libunwind@aa805e4
    @malbarbo
    malbarbo committed Jan 27, 2018
    Configuration menu
    Copy the full SHA
    2875f82 View commit details
    Browse the repository at this point in the history