-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Few fixes for multiple themes support feature #47686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1141,13 +1141,19 @@ kbd { | |
border: solid 1px; | ||
border-radius: 3px; | ||
box-shadow: inset 0 -1px 0; | ||
cursor: default; | ||
} | ||
|
||
#theme-picker { | ||
.theme-picker { | ||
position: absolute; | ||
left: 211px; | ||
top: 17px; | ||
top: 19px; | ||
} | ||
|
||
#theme-picker { | ||
padding: 4px; | ||
width: 27px; | ||
height: 29px; | ||
border: 1px solid; | ||
border-radius: 3px; | ||
cursor: pointer; | ||
|
@@ -1156,21 +1162,28 @@ kbd { | |
#theme-choices { | ||
display: none; | ||
position: absolute; | ||
left: -1px; | ||
top: 30px; | ||
left: 0; | ||
top: 28px; | ||
border: 1px solid; | ||
border-radius: 3px; | ||
z-index: 1; | ||
cursor: pointer; | ||
} | ||
|
||
#theme-choices > div { | ||
border-top: 1px solid; | ||
#theme-choices > button { | ||
border: none; | ||
width: 100%; | ||
padding: 4px; | ||
text-align: center; | ||
background: rgba(0,0,0,0); | ||
|
||
} | ||
|
||
#theme-choices > button:not(:first-child) { | ||
border-top: 1px solid; | ||
} | ||
|
||
@media (max-width: 700px) { | ||
#theme-picker { | ||
.theme-picker { | ||
left: 109px; | ||
top: 7px; | ||
z-index: 1; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -197,7 +197,7 @@ a.test-arrow { | |
|
||
#help dt { | ||
border-color: #bfbfbf; | ||
background: #fff; | ||
background: rgba(0,0,0,0); | ||
|
||
color: black; | ||
} | ||
|
||
|
@@ -352,7 +352,7 @@ pre.ignore:hover, .information:hover + pre.ignore { | |
} | ||
|
||
kbd { | ||
color: #444d56; | ||
color: #000; | ||
background-color: #fafbfc; | ||
border-color: #d1d5da; | ||
border-bottom-color: #c6cbd1; | ||
|
@@ -364,16 +364,20 @@ kbd { | |
background: #f0f0f0; | ||
} | ||
|
||
#theme-picker:hover, #theme-picker:focus { | ||
border-color: #ffb900; | ||
} | ||
|
||
#theme-choices { | ||
border-color: #e0e0e0; | ||
background-color: #353535; | ||
} | ||
|
||
#theme-choices > div { | ||
border-top: #e0e0e0; | ||
#theme-choices > button:not(:first-child) { | ||
border-top-color: #e0e0e0; | ||
} | ||
|
||
#theme-choices > div:hover { | ||
#theme-choices > button:hover, #theme-choices > button:focus { | ||
background-color: #444; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we know why this change makes it work? semantically, this should be a
<button>
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's a
<button>
inside this<div>
so i would assume that there's some layout trickery going on.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like @QuietMisdreavus said. :) Before it was buttons inside a button, now it's buttons inside a div. More logical for everyone (browsers included).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, i was missing the other
<button>
s being put inside this one. I like this version more.