Tweak presentation on lifetime trait mismatch #47791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
added
the
S-waiting-on-review
estebank
force-pushed
the
mismatched-trait-impl
branch
from
48d18c4
to
d61614d
Compare
When refering to named lifetime conflict, point only at the method's signature span instead of the entire method. When the expected and found sup and sub traces are the same, avoid redundant text.
estebank
force-pushed
the
mismatched-trait-impl
branch
from
d61614d
to
6c02699
Compare
- On mismatch between impl and trait method, point at the trait signature. - Point only at the method signature instead of the whole body on trait/impl mismatch errors.
estebank
force-pushed
the
mismatched-trait-impl
branch
from
69da0c2
to
67696be
Compare
nikomatsakis
approved these changes
Jan 29, 2018
|
@bors r+ |
|
📌 Commit 67696be has been approved by |
kennytm
added
S-waiting-on-bors
|
⌛ Testing commit 67696be with merge 1f8e6fa722cdc6f115d02703a84079a414c70997... |
|
💔 Test failed - status-appveyor |
bors
added a commit
that referenced
this pull request
Feb 3, 2018
Tweak presentation on lifetime trait mismatch - On trait/impl method discrepancy, add label pointing at trait signature. - Point only at method definition when referring to named lifetimes on lifetime mismatch. - When the sub and sup expectations are the same, tweak the output to avoid repeated spans. Fix #30790, CC #18759.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30790, CC #18759.