Skip to content

Conversation

@graydon
Copy link
Contributor

@graydon graydon commented Feb 5, 2013

Taking over where #4610 left off. Much rebasing and tidying.

@graydon graydon mentioned this pull request Feb 5, 2013
@z0w0
Copy link
Contributor

z0w0 commented Feb 9, 2013

It looks like tests failed but these tests are completely unrelated to rustpkg (I haven't touched anything outside of rustpkg except semver). Any idea what's going on here @graydon?

@graydon
Copy link
Contributor Author

graydon commented Feb 9, 2013

No, but curiously it also reliably locks up when I test locally. Hopefully I'll have more time to diagnose next week.

@z0w0
Copy link
Contributor

z0w0 commented Feb 13, 2013

I have a feeling this needs to be rebased and reviewed again, because it seems it got stuck between some bad commits.

@graydon
Copy link
Contributor Author

graydon commented Feb 13, 2013

I've been doing so daily in my own repo but am behind today.

It'd be substantially easier if the code synthesis part used quotes rather than the manual ast construction. I'll try to update it to work that way.

Sorry this is taking so long. Lots of churn. If you want to rebase ahead of me, by all means.

@catamorphism
Copy link
Contributor

I'm trying to rebase this. I'll see how far I get.

@graydon
Copy link
Contributor Author

graydon commented Feb 15, 2013

I did get to this today; have a version building with most of the ast code replaced with quotes. Don't bother. I'll post tomorrow.

@graydon
Copy link
Contributor Author

graydon commented Feb 15, 2013

(sorry for the mixed messages)

@catamorphism
Copy link
Contributor

ok

bors added a commit that referenced this pull request Feb 16, 2013
Taking over where #4610 left off. Much rebasing and tidying.
@bors bors closed this Feb 16, 2013
@z0w0
Copy link
Contributor

z0w0 commented Feb 16, 2013

This doesn't fold over crates (add_pkg_module), hence the main function isn't injected and imperative package scripts don't work. Adding the fold_crate function back in hits an ICE. Ouch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants