Handle path prefix mapping in a more stable way when computing the crate hash #48162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
added
the
S-waiting-on-review
nikomatsakis
approved these changes
Feb 12, 2018
nikomatsakis
requested changes
Feb 12, 2018
src/librustc/hir/map/collector.rs
Outdated
| @@ -147,11 +149,25 @@ impl<'a, 'hir> NodeCollector<'a, 'hir> { | |||
| (name1, dis1).cmp(&(name2, dis2)) | |||
| }); | |||
|
|
|||
| // We hash the names of all local source files so we don't have to | |||
There was a problem hiding this comment.
Actually, I find this comment a bit unclear. What exactly are we hashing here? Are these the "post-remapping" names being hashed?
There was a problem hiding this comment.
Correct, yes. I'll update the comment.
michaelwoerister
force-pushed
the
stabler-svh
branch
from
7a1b1ba to
0397fc1
Compare
|
@bors r=nikomatsakis |
|
📌 Commit 0397fc1 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
nikomatsakis
approved these changes
Feb 13, 2018
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 14, 2018
…omatsakis Handle path prefix mapping in a more stable way when computing the crate hash This hopefully fixes issue rust-lang#48019. cc @luser @infinity0
bors
added a commit
that referenced
this pull request
Feb 14, 2018
bors
added a commit
that referenced
this pull request
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully fixes issue #48019.
cc @luser @infinity0