Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc test command #48194

Merged
merged 1 commit into from
Feb 18, 2018
Merged

Doc test command #48194

merged 1 commit into from
Feb 18, 2018

Conversation

GuillaumeGomez
Copy link
Member

@QuietMisdreavus
Copy link
Member

Wouldn't this be better as a --doc flag to the existing test command, to only do doctests on paths that would do unit tests? Or am i interpreting this wrong?

@Mark-Simulacrum
Copy link
Member

Yeah, I think I agree with @QuietMisdreavus -- we should integrate this into test::Crate and test::CrateLibrustc by adding a --doc flag to x.py test (edit src/bootstrap/flags.rs).

@pietroalbini pietroalbini added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2018
@GuillaumeGomez
Copy link
Member Author

Ok, I'll update it in this way.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2018
@bors
Copy link
Contributor

bors commented Feb 15, 2018

☔ The latest upstream changes (presumably #48105) made this pull request unmergeable. Please resolve the merge conflicts.

@GuillaumeGomez GuillaumeGomez force-pushed the doc-test-command branch 2 times, most recently from fae6abc to b186364 Compare February 17, 2018 15:54
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 17, 2018

📌 Commit 8e46927 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 17, 2018
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 17, 2018
@GuillaumeGomez
Rollup merge of rust-lang#48194 - GuillaumeGomez:doc-test-command, r=…
6078dc2 
…Mark-Simulacrum

Doc test command

r? @Mark-Simulacrum
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 17, 2018
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 18, 2018
@GuillaumeGomez
Rollup merge of rust-lang#48194 - GuillaumeGomez:doc-test-command, r=…
8093b20 
…Mark-Simulacrum

Doc test command

r? @Mark-Simulacrum
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 18, 2018
Merged
bors added a commit that referenced this pull request Feb 18, 2018
@bors
Auto merge of #48322 - GuillaumeGomez:rollup, r=GuillaumeGomez
27a046e 
Rollup of 6 pull requests

- Successful merges: #48194, #48273, #48274, #48275, #48282, #48312
- Failed merges:
@bors bors merged commit 8e46927 into rust-lang:master Feb 18, 2018
@GuillaumeGomez GuillaumeGomez deleted the doc-test-command branch February 18, 2018 21:11
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @QuietMisdreavus @Mark-Simulacrum @bors @pietroalbini