Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Backport "Fix rustdoc test ICE" #48454

Merged
merged 1 commit into from
Feb 27, 2018
Merged

[beta] Backport "Fix rustdoc test ICE" #48454

merged 1 commit into from
Feb 27, 2018

Conversation

frewsxcv
Copy link
Member

@rust-highfive
Copy link
Collaborator

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 23, 2018
@frewsxcv frewsxcv mentioned this pull request Feb 23, 2018
Merged
@frewsxcv
Copy link
Member Author

r? @rust-lang/docs

@QuietMisdreavus
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 23, 2018

📌 Commit fe4ef51 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2018
@GuillaumeGomez
Copy link
Member

Shouldn't this be called forward-port?

@kennytm
Copy link
Member

kennytm commented Feb 24, 2018

@bors p=8

Beta "forward-port"

@bors
Copy link
Contributor

bors commented Feb 25, 2018

⌛ Testing commit fe4ef51 with merge e362d988606024fce887f9347e0872950a09160e...

@bors
Copy link
Contributor

bors commented Feb 26, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 26, 2018
@frewsxcv
Copy link
Member Author

looks like it timed out?

@kennytm
Copy link
Member

kennytm commented Feb 26, 2018

@bors retry #46903

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2018
@bors
Copy link
Contributor

bors commented Feb 27, 2018

⌛ Testing commit fe4ef51 with merge 70d3cbbac2d13cd1a11331a6cffc8021d9fd5d9e...

@bors
Copy link
Contributor

bors commented Feb 27, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2018
@kennytm
Copy link
Member

kennytm commented Feb 27, 2018

@bors retry #46903

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2018
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 27, 2018
@bors
Copy link
Contributor

bors commented Feb 27, 2018

⌛ Testing commit fe4ef51 with merge ed61aaa...

bors added a commit that referenced this pull request Feb 27, 2018
@bors
Auto merge of #48454 - frewsxcv:frewsxcv-backport, r=QuietMisdreavus
ed61aaa 
[beta] Backport "Fix rustdoc test ICE"

#48382
@bors
Copy link
Contributor

bors commented Feb 27, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2018
@alexcrichton
Copy link
Member

All dist jobs passed, merging manually

@alexcrichton alexcrichton merged commit fe4ef51 into rust-lang:beta Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@frewsxcv @rust-highfive @QuietMisdreavus @bors @GuillaumeGomez @kennytm @alexcrichton @steveklabnik