Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve --help performance for x.py #48569

Merged
merged 2 commits into from
Mar 3, 2018

Commits on Feb 27, 2018

  1. Improve --help performance for x.py

    Since compiling the bootstrap command doesn't require any submodules,
    we can skip updating submodules when a --help command is passed in.
    On my machine, this saves 1 minute if the submodules are already
    downloaded, and 10 minutes if run on a clean repo.
    
    This commit also adds a message before compiling/downloading anything
    when a --help command is passed in, to tell the user WHY --help
    takes so long to complete. It also points the user to the bootstrap
    README.md for faster help.
    
    Finally, this fixes one warning message that still referenced using
    make instead of x.py, even though x.py is now the standard way of
    building rust.
    Phlosioneer committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    ffb6291 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. Remove print_what_bootstrap_means

    It was an existing solution to tell the user why a --help command
    takes a long time to process. However, it would only print if the
    stage0 rust compiler needed to be downloaded, it came after
    update_submodules (which took a long time), and it was immediately
    followed by download messages and loading bars, meaning users could
    easily gloss over the message.
    
    This commit also moves the help message out of main(), and instead
    puts it at the top of bootstrap(). main() is intended to be minimal,
    only handling error messages.
    Phlosioneer committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    2269ff5 View commit details
    Browse the repository at this point in the history