Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: no need for the reference #48590

Merged
merged 1 commit into from
Mar 6, 2018
Merged

doc: no need for the reference #48590

merged 1 commit into from
Mar 6, 2018

Conversation

tshepang
Copy link
Member

Also, we are well within line length limit

@kennytm kennytm added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2018
@kennytm
Copy link
Member

kennytm commented Feb 28, 2018

Thanks for the PR @tshepang!

Would you mind changing the code at line 1592 too?

The examples for .inspect() (lines 1184 and 1193), .by_ref() (lines 1234 and 1250), .collect() (lines 1291, 1308, 1322 and 1347) and .partition() (line 1397) may also be updated.

(The & for try_fold() needs to be kept though)

@tshepang
doc: no need for the references
df8dd3f 
Also:
- apply some rustfmt love
- fix output of one example
@tshepang
Copy link
Member Author

Thanks for the thorough checking... I hopes I fixed it all.

@pietroalbini
Copy link
Member

Ping from the release team. This PR doesn't have any assigned reviewer, assigning someone randomly from the docs team.

r? @frewsxcv

@frewsxcv
Copy link
Member

frewsxcv commented Mar 5, 2018

looks great, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 5, 2018

📌 Commit df8dd3f has been approved by frewsxcv

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 6, 2018
@kennytm
Rollup merge of rust-lang#48590 - tshepang:more-simple, r=frewsxcv
6b8984d 
doc: no need for the reference

Also, we are well within line length limit
@kennytm kennytm mentioned this pull request Mar 6, 2018
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2018
@GuillaumeGomez
Rollup merge of rust-lang#48590 - tshepang:more-simple, r=frewsxcv
05c1bb9 
doc: no need for the reference

Also, we are well within line length limit
@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 6, 2018
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 6, 2018
@GuillaumeGomez
Rollup merge of rust-lang#48590 - tshepang:more-simple, r=frewsxcv
11b3e72 
doc: no need for the reference

Also, we are well within line length limit
@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 6, 2018
Closed
bors added a commit that referenced this pull request Mar 6, 2018
@bors
Auto merge of #48768 - kennytm:rollup, r=kennytm
2789b06 
Rollup of 14 pull requests

- Successful merges: #48403, #48432, #48546, #48573, #48590, #48657, #48727, #48732, #48753, #48754, #48761, #48474, #48507, #47463
- Failed merges:
@alexcrichton alexcrichton merged commit df8dd3f into rust-lang:master Mar 6, 2018
@tshepang tshepang deleted the more-simple branch March 6, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tshepang @kennytm @pietroalbini @frewsxcv @bors @alexcrichton