Rollup of 8 pull requests #48687
Closed
Rollup of 8 pull requests #48687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since compiling the bootstrap command doesn't require any submodules, we can skip updating submodules when a --help command is passed in. On my machine, this saves 1 minute if the submodules are already downloaded, and 10 minutes if run on a clean repo. This commit also adds a message before compiling/downloading anything when a --help command is passed in, to tell the user WHY --help takes so long to complete. It also points the user to the bootstrap README.md for faster help. Finally, this fixes one warning message that still referenced using make instead of x.py, even though x.py is now the standard way of building rust.
Makes the bench asked about on URLO 58x faster :)
It was an existing solution to tell the user why a --help command takes a long time to process. However, it would only print if the stage0 rust compiler needed to be downloaded, it came after update_submodules (which took a long time), and it was immediately followed by download messages and loading bars, meaning users could easily gloss over the message. This commit also moves the help message out of main(), and instead puts it at the top of bootstrap(). main() is intended to be minimal, only handling error messages.
Currently, we are producing headers for markdown files, which is generally not what we want. As such, passing this flag causes them to render normally.
…GuillaumeGomez add readme for librustdoc In the same vein as the other compiler-library readmes, here's one for rustdoc! It's mainly a "how does rustdoc even" blog-post-style writeup, but i wanted to have something in-repo so people could get a sense of what bits did what.
Disable NEON on musl ARMv7 `armv7-unknown-linux-musleabihf` target diverged a bit from `armv7-unknown-linux-gnueabihf` target. This PR re-syncs them. Fix rust-lang#47765.
…sakis Use `dyn trait` everywhere Based on rust-lang#48461 do not land unless both are reviewed.
… r=petrochenkov Improve --help performance for x.py Since compiling the bootstrap command doesn't require any submodules, we can skip updating submodules when a --help command is passed in. On my machine, this saves 1 minute if the submodules are already downloaded, and 10 minutes if run on a clean repo. This commit also adds a message before compiling/downloading anything when a --help command is passed in, to tell the user WHY --help takes so long to complete. It also points the user to the bootstrap README.md for faster help. Finally, this fixes one warning message that still referenced using make instead of x.py, even though x.py is now the standard way of building rust. Closes rust-lang#37305
…sakis Make TransitiveRelation thread safe. Avoid locking by using get_mut in some cases r? @nikomatsakis
impl Clone for ::std_unicode::char::{ToLowercase, ToUppercase}
Specialize Zip::nth for TrustedRandomAccess Fixes the performance difference observed in https://users.rust-lang.org/t/performance-difference-between-iterator-zip-and-skip-order/15743 Before: ``` test iter::bench_skip_then_zip ... bench: 154 ns/iter (+/- 4) test iter::bench_zip_then_skip ... bench: 4,725 ns/iter (+/- 225) ``` After: ``` test iter::bench_skip_then_zip ... bench: 154 ns/iter (+/- 2) test iter::bench_zip_then_skip ... bench: 81 ns/iter (+/- 19) ```
Don't produce TOCs for doc markdown files Currently, we are producing headers for markdown files, which is generally not what we want. As such, passing this flag causes them to render normally. https://doc.rust-lang.org/nightly/book/ is an example page currently where this is done incorrectly.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ p=10 (another rollup to leave running overnight. smaller and less riskier than the previous one) |
|
📌 Commit f5fc69a has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #48586) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dyn traiteverywhere #48477, Improve --help performance for x.py #48569, Make TransitiveRelation thread safe. Avoid locking by using get_mut in some cases #48587, impl Clone for ::std_unicode::char::{ToLowercase, ToUppercase} #48629, Specialize Zip::nth for TrustedRandomAccess #48635, Don't produce TOCs for doc markdown files #48680