Move ascii::escape_default to libcore #48735
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
I changed the annotations to stable with the version as |
|
r? @BurntSushi |
|
I don't know what our decision procedure is for moving things into |
|
Ah I think we'd go through the normal FCP process for this as it would be an insta-stable definition in libcore. @1011X I'd sort of expect though for the original definition to be deleted from somewhere, does that still need to happen? Also currently libcore for various technical reasons the tests go in |
|
Oh right, I'll delete them from std and re-export the ones in core, and move the tests as well. My bad, I'm still figuring out how std and core are organized. Since the tests are the same, should I delete the ones in |
|
Yeah no need to duplicate the tests as well, thanks! |
|
☔ The latest upstream changes (presumably #48768) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
kennytm
added
the
T-libs-api
rfcbot
added
the
proposed-final-comment-period
|
Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
alexcrichton
added
the
relnotes
rfcbot
added
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
@alexcrichton Got it! Thanks for the help :) |
|
Looks like CI may have some errors? |
|
@bors: r+ |
|
📌 Commit 1a16271 has been approved by |
bors
added
S-waiting-on-bors
Move ascii::escape_default to libcore As requested in #46409, the `ascii::escape_default` method has been added to the core library. All I did was copy over the `std::ascii` module file, remove the (redundant) `AsciiExt` trait, and change some of the documentation to match. None of the tests were changed. I wasn't sure how to handle the annotations. For `EscapeDefault` and `escape_default()`, I changed them to `#[unstable(feature = "core_ascii", issue = "46409")]`. Is that alright? Or should I leave them as they were?
|
☀️ Test successful - status-appveyor, status-travis |
Correct a few stability attributes * `const_indexing` language feature was stabilized in 1.26.0 by #46882 * `Display` impls for `PanicInfo` and `Location` were stabilized in 1.26.0 by #47687 * `TrustedLen` is still unstable so its impls should be as well even though `RangeInclusive` was stabilized by #47813 * `!Send` and `!Sync` for `Args` and `ArgsOs` were stabilized in 1.26.0 by #48005 * `EscapeDefault` has been stable since 1.0.0 so should continue to show that even though it was moved to core in #48735 This could be backported to beta like #49612
As requested in #46409, the
ascii::escape_defaultmethod has been added to the core library. All I did was copy over thestd::asciimodule file, remove the (redundant)AsciiExttrait, and change some of the documentation to match. None of the tests were changed.I wasn't sure how to handle the annotations. For
EscapeDefaultandescape_default(), I changed them to#[unstable(feature = "core_ascii", issue = "46409")]. Is that alright? Or should I leave them as they were?