Add functionality for gating feature flags on epochs ; rejigger epoch lints #48801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Manishearth
force-pushed
the
epoch-features
branch
3 times, most recently
from
83f60ca to
f249692
Compare
nikomatsakis
requested changes
Mar 8, 2018
| let mut features = Features::new(); | ||
|
|
||
| let mut feature_checker = FeatureChecker::default(); | ||
|
|
||
| for &(.., f_epoch, set) in ACTIVE_FEATURES.iter() { | ||
| if let Some(f_epoch) = f_epoch { | ||
| if epoch >= f_epoch { |
There was a problem hiding this comment.
e.g., // compile-flags: -Zepoch=2018, and then use dyn Trait
|
☔ The latest upstream changes (presumably #46882) made this pull request unmergeable. Please resolve the merge conflicts. |
nikomatsakis
added
S-waiting-on-author
Manishearth
force-pushed
the
epoch-features
branch
2 times, most recently
from
5baa8bb to
fc5ad32
Compare
|
Added test. Oh, also, I'm going to make bare_trait_object and unreachable_pub not be epoch lints -- I'll keep epoch lints to be actual breaking changes like tyvar_rptr and the keywords, and these lints can go ungrouped for now (we can group them later if we wish?) |
Manishearth
force-pushed
the
epoch-features
branch
2 times, most recently
from
779c10c to
9272579
Compare
Manishearth
changed the title
Manishearth
force-pushed
the
epoch-features
branch
from
9272579 to
d9f0c16
Compare
nikomatsakis
approved these changes
Mar 8, 2018
| pub trait Foo {} | ||
|
|
||
| // should compile without the dyn trait feature flag | ||
| fn foo(x: &dyn Foo) {} |
|
@bors r+ |
|
📌 Commit d9f0c16 has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #48849) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Manishearth
force-pushed
the
epoch-features
branch
from
d9f0c16 to
a08cfc4
Compare
|
@bors r=nikomatsakis |
|
📌 Commit a08cfc4 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 9, 2018
…atsakis Add functionality for gating feature flags on epochs ; rejigger epoch lints fixes rust-lang#48794 r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #48794
r? @nikomatsakis