Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unnecessary IdxSet methods #48840

Merged
merged 3 commits into from
Mar 14, 2018
Merged

Remove some unnecessary IdxSet methods #48840

merged 3 commits into from
Mar 14, 2018

Conversation

varkor
Copy link
Member

@varkor varkor commented Mar 8, 2018

This replaces IdxSet:: reset_to_empty with IdxSet:: clear, and IdxSet::elems/IdxSet::each_bit with IdxSet::iter. Based on some comments on #rustc.

r? @pnkfelix

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 8, 2018
@pietroalbini
Copy link
Member

Ping from triage @pnkfelix! This PR needs your review.

@pnkfelix
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 12, 2018

📌 Commit f69a099 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2018
@michaelwoerister
Copy link
Member

@bors rollup

@kennytm kennytm mentioned this pull request Mar 14, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Mar 14, 2018
@kennytm
Rollup merge of rust-lang#48840 - varkor:idxset-cleanup, r=pnkfelix
b5f102c 
Remove some unnecessary IdxSet methods

This replaces `IdxSet:: reset_to_empty` with `IdxSet:: clear`, and `IdxSet::elems`/`IdxSet::each_bit` with `IdxSet::iter`. Based on some [comments on #rustc](https://botbot.me/mozilla/rustc/2018-01-23/?msg=96063396).

r? @pnkfelix
bors added a commit that referenced this pull request Mar 14, 2018
@bors
Auto merge of #49008 - kennytm:rollup, r=kennytm
521d91c 
Rollup of 12 pull requests

- Successful merges: #48765, #48831, #48840, #48964, #48970, #48971, #48981, #48988, #48991, #48966, #48993, #48874
- Failed merges:
@bors bors merged commit f69a099 into rust-lang:master Mar 14, 2018
@varkor varkor deleted the idxset-cleanup branch March 15, 2018 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@varkor @pietroalbini @pnkfelix @bors @michaelwoerister @rust-highfive