Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggest ! instead of erroneous not on if/while block parse failure #48858

Closed
wants to merge 1 commit into from
Closed

suggest ! instead of erroneous not on if/while block parse failure #48858

wants to merge 1 commit into from

Commits on Mar 8, 2018

  1. suggest ! instead of erroneous not on if/while block parse failure 

    Impressing confused Python users with magical diagnostics is probably
worth this very slight (only 25ish lines) extra complexity in the
parser?

FIXME comments have been left to note that the formatting after
autofixing the suggestion (with `rustfix` or an RLS-powered IDE) won't
be optimal. (It doesn't look like any of the existing `CodeMap` methods
make it easy to adjust the span.)

Resolves rust-lang#46836.
    @zackmdavis
    zackmdavis committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    b468b0e View commit details
    Browse the repository at this point in the history