Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin, Unpin, PinBox #49058

Merged
merged 9 commits into from
Mar 20, 2018
Merged

Pin, Unpin, PinBox #49058

merged 9 commits into from
Mar 20, 2018

Conversation

withoutboats
Copy link
Contributor

Implementing rust-lang/rfcs#2349 (do not merge until RFC is merged)

@bors r? @cramertj

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2018
@cramertj
Copy link
Member

This looks great to me! s/issue = "0"/issue = "<tracking issue #>" once a tracking issue is opened, but r=me otherwise.

@kennytm kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2018
@withoutboats withoutboats mentioned this pull request Mar 18, 2018
Closed
3 tasks
@withoutboats
Copy link
Contributor Author

@bors r=@cramertj p=100

@bors
Copy link
Contributor

bors commented Mar 18, 2018

📌 Commit 2797aac has been approved by @cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 18, 2018
@bors
Copy link
Contributor

bors commented Mar 18, 2018

⌛ Testing commit 2797aac with merge f8224c2851ab70344300e84cf5755efead40b453...

@bors
Copy link
Contributor

bors commented Mar 19, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 19, 2018
@kennytm kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2018
@withoutboats
Copy link
Contributor Author

htmldoc failure, no idea how it could be related to this change

@kennytm
Copy link
Member

kennytm commented Mar 19, 2018

Blocked by #49123.

@withoutboats
Copy link
Contributor Author

I can change the order of the bounds and it should pass?

@withoutboats
Copy link
Contributor Author

@kennytm also p=100 was because futures 0.2 is blocked on this landing in nightly (i assume thats what your confused face was about)

@kennytm
Copy link
Member

kennytm commented Mar 19, 2018

@withoutboats if you need to change the test I suggest you // ignore it, because changing the order may break future PRs instead.

I'd like to let #49091 get merged first, since it fixes a very commonly encountered ICE.

@bors
Copy link
Contributor

bors commented Mar 19, 2018

⌛ Testing commit 2797aac with merge a1439aa3ff6b44a1cd9d80f48ed4b6f5f0afd071...

@alexcrichton
Copy link
Member

@bors: retry

sorry bors, this already failed

@alexcrichton
Copy link
Member

@bors: retry r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 19, 2018
@bors
Copy link
Contributor

bors commented Mar 19, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2018
@kennytm
Copy link
Member

kennytm commented Mar 19, 2018

@bors r=cramertj

@bors
Copy link
Contributor

bors commented Mar 19, 2018

📌 Commit e4d0d66 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2018
@kennytm kennytm mentioned this pull request Mar 19, 2018
Closed
@withoutboats
Copy link
Contributor Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 19, 2018
@withoutboats
Copy link
Contributor Author

@bors r=cramertj

@bors
Copy link
Contributor

bors commented Mar 19, 2018

📌 Commit 540021f has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2018
@bors
Copy link
Contributor

bors commented Mar 19, 2018

⌛ Testing commit 540021f with merge 6bfa7d0...

bors added a commit that referenced this pull request Mar 19, 2018
@bors
Auto merge of #49058 - withoutboats:pin, r=cramertj
6bfa7d0 
Pin, Unpin, PinBox

Implementing rust-lang/rfcs#2349 (do not merge until RFC is merged)

@bors r? @cramertj
@bors
Copy link
Contributor

bors commented Mar 20, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing 6bfa7d0 to master...

@bors bors merged commit 540021f into rust-lang:master Mar 20, 2018
@SimonSapin SimonSapin mentioned this pull request Mar 21, 2018
Merged
@cramertj cramertj mentioned this pull request Mar 23, 2018
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cramertj cramertj

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@withoutboats @cramertj @bors @kennytm @alexcrichton @rust-highfive